Closed Bug 1162791 Opened 5 years ago Closed 5 years ago

Add-ons should be enabled by default when installed

Categories

(DevTools Graveyard :: WebIDE, defect, P1)

defect

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: drs, Assigned: fabrice)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

Currently, you have to go into Gaia's Settings menu and enable an add-on after flashing it using WebIDE. Instead, we should enable it by default.
Alex, is this something you can manage for our Spark v1 release?
Flags: needinfo?(poirot.alex)
Do you know what would it take to enable the addon??

As it looks like we are already doing what's needed.

The webapps actors calls updateAppHandlers:
  http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/webapps.js#277
Which itself call UserCustomizations.register:
  http://mxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm#2128
And I thought that's all what needed to make an addon work??
No, add-ons must be enabled as well. I'm not sure how to do that within Gecko. Fabrice, could you help out Alex?
Flags: needinfo?(fabrice)
That's not the right fix, but I know what to do. Keeping the needinfo to fix this one later.
Simply make sure that we never pass an undefined value for app.enabled even if it's not specified by eg. preloaded apps.
Assignee: nobody → fabrice
Flags: needinfo?(fabrice)
Attachment #8608279 - Flags: review?(ferjmoreno)
Attachment #8608279 - Flags: review?(ferjmoreno) → review+
https://hg.mozilla.org/mozilla-central/rev/b29b0dfd8ac6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: needinfo?(poirot.alex)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.