Closed Bug 1162808 Opened 5 years ago Closed 5 years ago

Add splash_screens support to web manifest processor

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Add support for processing splash_screens to web manifest, and generalize IconsParser into an ImageParser while at it.
Blocks: webmanifest
Assignee: nobody → mcaceres
Ehsan, the changes are actually smaller than they appear (mostly a refactor to DRY-up icon and splash_screens processing). 

What's different:  
    * Took IconsProcessor out of ManifestProcessor.
    * Converted IconsProcessor into ImageObjectProcessor.
    * Made extractValue a separate resource, as it's used by multiple
      processors.
    * Taught manifest processor about splash_screens.
    * icons member now uses ImageObjectProcessor.
    * Icon tests are now ImageProcessor tests.
    * Fixed a few typos.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=62ec0a163f19
Attachment #8604745 - Flags: review?(ehsan)
Attachment #8604745 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Argh, I think that's git patch... just double checking...
Blocks: 1164235
No longer blocks: 1164235
Attached patch HR patch set (obsolete) — Splinter Review
Attachment #8604745 - Attachment is obsolete: true
Keywords: checkin-needed
Hg even... is all good ^_^
Attachment #8604902 - Attachment is obsolete: true
Needs rebasing.
Keywords: checkin-needed
Attached patch RebaseSplinter Review
Attachment #8605380 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/357d4c821c81
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.