Closed Bug 1162846 Opened 5 years ago Closed 5 years ago

Don't str.find in moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

str.find('foo') != -1 is less readable than 'foo' in str, and, as a matter of fact, led me to make a mistake in bug 941450.
Depends on: 1162847
Blocks: 1162847
No longer depends on: 1162847
No longer blocks: 941450
Comment on attachment 8603166 [details] [diff] [review]
Don't use str.find in moz.build

>+if CONFIG['OS_ARCH'] == 'SunOS' and '86' in CONFIG['OS_TEST']:
>+if CONFIG['OS_ARCH'] == 'SunOS' and '86' not in CONFIG['OS_TEST']:

It might make sense to combine the SunOS logic into one spot, rather than have the x86 sources in one part and the sparc sources in another. Eg:

if CONFIG['OS_ARCH'] == 'SunOS':
   if '86' in CONFIG['OS_TEST']:
      x86_64 / x86 stuff
   else:
      sparc stuff

But that's only tangentially related.
Attachment #8603166 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/fbb4a7ee9990
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.