Closed Bug 1162852 Opened 5 years ago Closed 5 years ago

Small cleanup in the gyp reader code

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(4 files)

With bug 1162851 and 1162845, there is no more reason to keep context variables specific to gyp processing.
With TemplateContexts keeping the name of the associated template, and the
Gyp context being declared as a TemplateContext, it is now possible to know
the equivalent of IS_GYP_DIR just by looking at the template name.
Attachment #8603187 - Flags: review?(gps)
We now have corresponding variables in moz.build contexts that can be used
instead.
Attachment #8603188 - Flags: review?(gps)
Attachment #8603189 - Flags: review?(gps)
Attachment #8603187 - Flags: review?(gps) → review+
Comment on attachment 8603188 [details] [diff] [review]
Remove EXTRA_COMPILE_FLAGS

Review of attachment 8603188 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: python/mozbuild/mozbuild/frontend/gyp_reader.py
@@ +221,5 @@
> +                    suffix_map[e]
> +                    for e in extensions if e in suffix_map
> +                )
> +                for var in variables:
> +                    context[var] += flags

Should this be using .extend?
Attachment #8603188 - Flags: review?(gps) → review+
Attachment #8603189 - Flags: review?(gps) → review+
Attachment #8603190 - Flags: review?(gps) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.