1162852 - Small cleanup in the gyp reader code

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

With bug 1162851 and 1162845, there is no more reason to keep context variables specific to gyp processing.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't set IS_GYP_DIR from the gyp_reader

With TemplateContexts keeping the name of the associated template, and the
Gyp context being declared as a TemplateContext, it is now possible to know
the equivalent of IS_GYP_DIR just by looking at the template name.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Remove EXTRA_COMPILE_FLAGS

We now have corresponding variables in moz.build contexts that can be used
instead.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Remove EXTRA_ASSEMBLER_FLAGS

Comment 4

[Mike Hommey [:glandium]]

Attachment: Remove the VARIABLES method of GypContext now it is doing nothing

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8603188 [details] [diff] [review]
Remove EXTRA_COMPILE_FLAGS

Review of attachment 8603188 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: python/mozbuild/mozbuild/frontend/gyp_reader.py
@@ +221,5 @@
> +                    suffix_map[e]
> +                    for e in extensions if e in suffix_map
> +                )
> +                for var in variables:
> +                    context[var] += flags

Should this be using .extend?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a48557804303
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b852bac0506
https://hg.mozilla.org/integration/mozilla-inbound/rev/f51c116920fc
https://hg.mozilla.org/integration/mozilla-inbound/rev/8591b2d16a33

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a48557804303
https://hg.mozilla.org/mozilla-central/rev/6b852bac0506
https://hg.mozilla.org/mozilla-central/rev/f51c116920fc
https://hg.mozilla.org/mozilla-central/rev/8591b2d16a33