Closed Bug 1162896 Opened 9 years ago Closed 9 years ago

Links in about:crashes have two focus rings

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: dao, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

When focusing a link in about:crashes, we draw two focus rings and the content below the link is pushed down slightly.
Flags: qe-verify-
Flags: firefox-backlog+
Attached patch Bug1162896.patch (obsolete) — Splinter Review
This patch removes the html|a:-moz-focusring selector which creates the second focus ring.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8603579 - Flags: review?(dao)
Attachment #8603579 - Flags: review?(dao) → review+
Keywords: checkin-needed
Attached patch Bug1162896.patchSplinter Review
Oops, I had to rebase the patch to apply correctly.

carrying over r+
Attachment #8603579 - Attachment is obsolete: true
Attachment #8603703 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/963ad99e6edc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla41
Iteration: --- → 40.3 - 11 May
Richard, can you please request approval for landing this on aurora for Firefox 40?
Flags: needinfo?(richard.marti)
Comment on attachment 8603703 [details] [diff] [review]
Bug1162896.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1161161
[User impact if declined]: Weird jumping of lines
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: low, only CSS change
[String/UUID change made/needed]:
Flags: needinfo?(richard.marti)
Attachment #8603703 - Flags: approval-mozilla-aurora?
Comment on attachment 8603703 [details] [diff] [review]
Bug1162896.patch

Simple enough. Aurora+
Attachment #8603703 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.