Closed
Bug 1162896
Opened 9 years ago
Closed 9 years ago
Links in about:crashes have two focus rings
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
People
(Reporter: dao, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
2.07 KB,
patch
|
Paenglab
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When focusing a link in about:crashes, we draw two focus rings and the content below the link is pushed down slightly.
Flags: qe-verify-
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
This patch removes the html|a:-moz-focusring selector which creates the second focus ring.
Reporter | ||
Updated•9 years ago
|
Attachment #8603579 -
Flags: review?(dao) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 2•9 years ago
|
||
Oops, I had to rebase the patch to apply correctly. carrying over r+
Attachment #8603579 -
Attachment is obsolete: true
Attachment #8603703 -
Flags: review+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/963ad99e6edc
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/963ad99e6edc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla41
Updated•9 years ago
|
Iteration: --- → 40.3 - 11 May
Reporter | ||
Comment 5•9 years ago
|
||
Richard, can you please request approval for landing this on aurora for Firefox 40?
Flags: needinfo?(richard.marti)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8603703 [details] [diff] [review] Bug1162896.patch Approval Request Comment [Feature/regressing bug #]: Bug 1161161 [User impact if declined]: Weird jumping of lines [Describe test coverage new/current, TreeHerder]: [Risks and why]: low, only CSS change [String/UUID change made/needed]:
Flags: needinfo?(richard.marti)
Attachment #8603703 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8603703 [details] [diff] [review] Bug1162896.patch Simple enough. Aurora+
Attachment #8603703 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•