1162999 - Need to skip first-run in UITests

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Aaron Train [:aaronmt]]

In startup we can tap 'Browse' but it would be nice to skip the first-run all-together.

Comment 1

[Stephan Leroux [:sleroux]]

Couple of ideas for resolving this:

1. I've had problems in the past where tests were not being properly run because of logic that was being executed in the AppDelegate every time a test case started up. A solution would be to create a Test AppDelegate and have a build flag in main.m that would direct the app to the correct app delegate. The nice thing about this solution is that we don't add any test exceptions to the production code.

2. Another solution would be to hide certain functionality in app start up behind build flags that would be configured to avoid certain logic from running on app launch.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/467

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8606008 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/467

Looks good!

Comment 4

[Stephan Leroux [:sleroux]]

Not related to this patch but there seems to be 2 failing tests:

https://www.dropbox.com/s/s2rla5x33ek8fc1/Screenshot%202015-05-15%2008.32.15.png?dl=0

Comment 5

[Brian Nicholson (:bnicholson)]

(In reply to Stephan Leroux from comment #4)
> Not related to this patch but there seems to be 2 failing tests:
> 
> https://www.dropbox.com/s/s2rla5x33ek8fc1/Screenshot%202015-05-15%2008.32.15.
> png?dl=0

Yeah, wesj mentioned that too -- somehow related to the on-screen keyboard being enabled. I'll look into it.