1163020 - --jitflags=none is broken in jit_test.py

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

jit_test.py with --jitflags=none or without any jitflags related option runs only asm.js tests.

JITFLAGS['none'] should contain an empty list for jit_test.py.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Fix --jitflags=none or no --jitflags in jit_test.py.

Added empty list in JITFLAGS['none'] in tests.py, for jit_test.py,

Also, in that case, it should be better to return None for jstests.py, so added keyword arguments to override the return value for 'none' case.

This also needs aurora/esr38 uplift, since patches in bug 1161410 were uplifted.

Comment 2

[Tooru Fujisawa [:arai]]

Pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1fb35b98156
--jitflags=none is not used in automation tho, just to confirm no other thing is broken by this change.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8603404 [details] [diff] [review]
Fix --jitflags=none or no --jitflags in jit_test.py.

Review of attachment 8603404 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks for the fix!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d732da9298fa

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 8603404 [details] [diff] [review]
Fix --jitflags=none or no --jitflags in jit_test.py.

for aurora
Approval Request Comment
[Feature/regressing bug #]: bug 1161410
[User impact if declined]: no user impact, but automated test (jit_test.py) doesn't work correctly, and most tests are skipped on local run (no impact for treeherder)
[Describe test coverage new/current, TreeHerder]: now mozilla-inbound test is running https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d732da9298fa
[Risks and why]: Low, since it's test-only (test harness bug fix)
[String/UUID change made/needed]: None

for esr38
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: buggy patch was uplifted there in bug 1161410
User impact if declined: no user impact, but automated test (jit_test.py) doesn't work correctly, and most tests are skipped on local run (no impact for treeherder)
Fix Landed on Version: landed to mozilla-inbound, which will be firefox40
Risk to taking this patch (and alternatives if risky):  Low, since it's test-only (test harness bug fix)
String or UUID changes made by this patch: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8603404 [details] [diff] [review]
Fix --jitflags=none or no --jitflags in jit_test.py.

These can land with a=test-only

Comment 7

[Tooru Fujisawa [:arai]]

Thanks!

https://hg.mozilla.org/releases/mozilla-aurora/rev/d7313d188c2f

https://hg.mozilla.org/releases/mozilla-esr38/rev/f33d3235e2b7

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d732da9298fa