1163030 - URL: stop escaping ` in query

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Anne (:annevk)]

Per excellent research in bug 1152455 comment 6 we're the only browser that escapes ` in the query component of a URL. We should stop doing that.

We should ignore that https://url.spec.whatwg.org/ lists 0x60 as a byte to escape. I'll make sure that gets fixed eventually.

Comment 1

[Anne (:annevk)]

Issue with the Standard is tracked in https://github.com/whatwg/url/issues/17 but please don't wait for that to get fixed. interop is more important.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: URL: stop escaping ` in query

Comment 3

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=501957f15de1

Comment 4

[Valentin Gosu [:valentin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb36b34ff5f9ef03cf39acf35ad99bd8d106d066
Bug 1163030 - URL: stop escaping ` in query r=mcmanus

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad57ca8421315256984e7e1eaad3e205beb17460
Bug 1163030 - Fix WPT expectfails for URLs containing ` in query a=testonly

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb36b34ff5f9
https://hg.mozilla.org/mozilla-central/rev/ad57ca842131

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fb36b34ff5f9
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ad57ca842131

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion