1163056 - InkCollector activation at first PEN event.

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Maksim Lebedev]

Class InkCollector helps fire POINTER_LEAVE event for PEN device in some case.

Current implementation:
Activation of InkCollecor class needs that PEN device will be touched
(In this case MOUSE_DOWN will be fired).

Should it behavior be changed for detect just first PEN event?
(For example MOUSE_MOVE, not only MOUSE_DOWN)

Comment 1

[Maksim Lebedev]

Could You please notify your opinion about changing such behavior?

Comment 2

[Matt Brubeck (:mbrubeck)]

Yes, this should be fixed.  We should dispatch a pointerleave event whenever a pen moves out of the hit test boundaries of an element and its descendants, whether the pen is down or not.

Related to this, the spec also says "User agents MUST also fire a pointer event named pointerleave when a pen stylus leaves hover range detectable by the digitizer."

Comment 3

[Maksim Lebedev]

Attachment: pen_activation_ver1.diff

+ Added: InkCollector class activates at first PEN event.

Suggestions and comments and objections are very welcome.

Comment 4

[Maksim Lebedev]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=785e36b2222a

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8605229 [details] [diff] [review]
pen_activation_ver1.diff

Looks ok to me code wise.

Comment 6

[Maksim Lebedev]

If there are no objections, I put checkin-needed flag.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77bf0be4186f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77bf0be4186f