InkCollector activation at first PEN event.

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alessarik, Assigned: alessarik)

Tracking

Trunk
Firefox 41
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 affected, firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Class InkCollector helps fire POINTER_LEAVE event for PEN device in some case.

Current implementation:
Activation of InkCollecor class needs that PEN device will be touched
(In this case MOUSE_DOWN will be fired).

Should it behavior be changed for detect just first PEN event?
(For example MOUSE_MOVE, not only MOUSE_DOWN)
(Assignee)

Comment 1

4 years ago
Could You please notify your opinion about changing such behavior?
Blocks: 1122211
Flags: needinfo?(mbrubeck)
Flags: needinfo?(jmathies)
Flags: needinfo?(bugs)
Yes, this should be fixed.  We should dispatch a pointerleave event whenever a pen moves out of the hit test boundaries of an element and its descendants, whether the pen is down or not.

Related to this, the spec also says "User agents MUST also fire a pointer event named pointerleave when a pen stylus leaves hover range detectable by the digitizer."
Flags: needinfo?(mbrubeck)
Flags: needinfo?(jmathies)
Flags: needinfo?(bugs)
(Assignee)

Updated

4 years ago
Depends on: 1016232
(Assignee)

Comment 3

4 years ago
Created attachment 8605229 [details] [diff] [review]
pen_activation_ver1.diff

+ Added: InkCollector class activates at first PEN event.

Suggestions and comments and objections are very welcome.
Assignee: nobody → alessarik
Attachment #8605229 - Flags: review?(jmathies)
Attachment #8605229 - Flags: feedback?(mbrubeck)

Comment 5

4 years ago
Comment on attachment 8605229 [details] [diff] [review]
pen_activation_ver1.diff

Looks ok to me code wise.
Attachment #8605229 - Flags: review?(jmathies) → review+
(Assignee)

Comment 6

4 years ago
If there are no objections, I put checkin-needed flag.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/77bf0be4186f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Attachment #8605229 - Flags: feedback?(mbrubeck)
You need to log in before you can comment on or make changes to this bug.