Closed Bug 1163062 Opened 5 years ago Closed 5 years ago

Make e10s strings localizable

Categories

(Firefox :: General, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

Per bug 1161260 comment 14, there's value in un-hardcoding these strings and making them localizable, even if they won't be used for release, because they might be used up to Beta. It's better to start localizing them now so that there's a one cycle of buffer to get them translated for beta.
This moves all strings into localizable files and adds a localization note explaining they are only for pre-release.

The only thing that this doesn't translate are the "disabled reasons" that are hard-coded in nsAppRunner.cpp. It would involve some more code changes and I believe it's not worth doing that for something that's temporary.
Attachment #8603436 - Flags: review?(ttaubert)
Comment on attachment 8603436 [details] [diff] [review]
make-e10s-strings-localizable

Review of attachment 8603436 [details] [diff] [review]:
-----------------------------------------------------------------

r=me without the pref change.

There were more instances of "help testing multi-process", "enable multi-process", etc. This sounds weird to me but I'm not a native speaker so I'll bend to whatever additional opinion you can get about this :)

::: browser/locales/en-US/chrome/browser/preferences/main.dtd
@@ +41,5 @@
>  <!ENTITY separateProfileMode.label        "Allow &brandShortName; and Firefox to run at the same time">
>  <!ENTITY useFirefoxSync.label             "Tip: This uses separate profiles. Use Sync to share data between them.">
>  <!ENTITY getStarted.label                 "Start using Sync…">
> +
> +<!ENTITY e10sEnabled.label                "Enable multi-process">

Maybe "Enable multi-process Firefox"? The current feels different than "Enable e10s", not sure.
Attachment #8603436 - Flags: review?(ttaubert) → review+
I dropped the "E10S" name as Dcamp suggested in bug 1161260 comment 5 that it doesn't mean much to the regular user. So that's why there are more occurrences of "multi-process" now. I changed the string you suggested to "Enable multi-process &brandShortName;", it does look better.
https://hg.mozilla.org/mozilla-central/rev/ff55066a395b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Blocks: 1163416
Iteration: --- → 40.3 - 11 May
Points: --- → 1
Flags: qe-verify-
Depends on: 1198920
You need to log in before you can comment on or make changes to this bug.