Closed
Bug 1163083
Opened 11 years ago
Closed 11 years ago
The horizontal scrolling experience is terrible when viewing a log on Treeherder
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: seth, Assigned: wlach)
Details
Attachments
(1 external file)
Take a look here for an example:
https://treeherder.mozilla.org/logviewer.html#?job_id=7338172&repo=try
Why is it so slow and painful to scroll to the right? (Or back to the left once you've done so, for that matter?)
| Reporter | ||
Comment 1•11 years ago
|
||
(In case this is platform-specific, I'm viewing this on OS X with the current Nightly.)
| Assignee | ||
Comment 2•11 years ago
|
||
I noticed this as well when trying to help out with bug 1144728. I don't know what the exact problem is (layout recalculation?) but I noticed that Chrome doesn't exhibit the same behavior. I think the simplest fix is to just wrap long lines so you don't need to horizontally scroll. This is what Firefox does by default for long text files.
| Assignee | ||
Comment 3•11 years ago
|
||
See github page for more details
Assignee: nobody → wlachance
Attachment #8603492 -
Flags: review?(cdawson)
Comment 4•11 years ago
|
||
Comment on attachment 8603492 [details] [review]
PR
wlach: I think once you remove the trim() this is fine to merge. OR only do a _.trimRight() like you mentioned:
https://lodash.com/docs#trimRight
Attachment #8603492 -
Flags: review?(cdawson) → review+
Comment 5•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/29ee59bdb80262be9c5cd542f741ab61ddf7ebf0
Bug 1163083 - Improve scrolling behaviour inside log viewer
* Use flexbox for layout, which ensures that scrollbars are always inside
viewport
* Wrap lines instead of providing horizontal scrollbars
* Trim extraneous whitespace off end of log lines before displaying
| Assignee | ||
Comment 6•11 years ago
|
||
I just removed the trimming altogether. In retrospect, I don't think it helps anything.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Treeherder Bugbot from comment #5)
> Commit pushed to master at https://github.com/mozilla/treeherder-ui
>
> https://github.com/mozilla/treeherder-ui/commit/
> 29ee59bdb80262be9c5cd542f741ab61ddf7ebf0
> Bug 1163083 - Improve scrolling behaviour inside log viewer
>
> * Use flexbox for layout, which ensures that scrollbars are always inside
> viewport
> * Wrap lines instead of providing horizontal scrollbars
> * Trim extraneous whitespace off end of log lines before displaying
And apparently forgot to update the commit message, sigh. Oh well.
Comment 8•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/afc3d2f5011f629e853991f5358b33381b763e4c
Bug 1163083 - Improve scrolling behaviour inside log viewer
* Use flexbox for layout, which ensures that scrollbars are always inside
viewport
* Wrap lines instead of providing horizontal scrollbars
* Trim extraneous whitespace off end of log lines before displaying
Updated•4 years ago
|
Component: Treeherder: Log Viewer → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•