1163107 - Changes to font size not respected when using relative filter units

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Tobias Schneider [:tobytailor]]

Attachment: test case

When changing the font size after a filter using relative units was set, the change is not respected when the filter gets applied.

Comment 1

[Markus Stange [:mstange]]

Hmm. Maybe we should just define the current Firefox behavior as correct. It's similar to how ctx.font works:

> When the 'font-size' component is set to lengths using percentages, 'em' or
> 'ex' units, or the 'larger' or 'smaller' keywords, these must be interpreted
> relative to the computed value of the 'font-size' property of the font style
> source node at the time that the attribute is set, if that is an element.
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
http://www.w3.org/TR/2015/WD-2dcontext-20150514/#dom-context-2d-font

Comment 2

[Tobias Schneider [:tobytailor]]

I agree, It makes most sense to make it work just like ctx.font.

Comment 3

[Tobias Schneider [:tobytailor]]

Attachment: test case

Change test to reflect previously discussed behavior.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8738904 [details] [diff] [review]
test case

Review of attachment 8738904 [details] [diff] [review]:
-----------------------------------------------------------------

Can you also add a test that makes sure that we *don't* react to font changes that happen after the filter was set?

Comment 5

[Tobias Schneider [:tobytailor]]

That's what the test is already doing. It changes the font size to 20px after setting the filter, which should get ignored.

Comment 6

[Markus Stange [:mstange]]

Oh, right.

Comment 7

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7164569f833c

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91fb7cf2e5fe

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/91fb7cf2e5fe