Closed
Bug 1163111
Opened 9 years ago
Closed 9 years ago
Update Pocket code to latest version (May 7th code drop)
Categories
(Firefox :: Pocket, defect, P1)
Firefox
Pocket
Tracking
()
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
476.36 KB,
patch
|
Dolske
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1161654 +++
Updated•9 years ago
|
Priority: -- → P1
Comment 1•9 years ago
|
||
Comment on attachment 8603509 [details] [diff] [review] Patch Review of attachment 8603509 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/pocket/main.js @@ +804,5 @@ > + var panelMessageId = prefixedMessageId(panelId + '_' + messageId); > + > + var AnswerEvt = doc.createElement("PKTMessage"); > + AnswerEvt.setAttribute("payload", JSON.stringify([payload])); > + documentElement.appendChild(AnswerEvt); Just happened to notice this -- AFAICT the only purpose if the element being created here (and on the other side, for messages in the reverse direction) is to call .dispatchEvent on it. I think that could just be done directly on the iframe's document, then no need to create nodes + append them + remove them. Just a tiny suggestion for the future.
Attachment #8603509 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/adadd752ff08
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8603509 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: pocket [User impact if declined]: new UI and misc bug fixes for Pocket from the Pocket engineering team [Describe test coverage new/current, TreeHerder]: manual QA testing [Risks and why]: risks limited to Pocket functionality, manual smoke testing locally [String/UUID change made/needed]: none
Attachment #8603509 -
Flags: approval-mozilla-release?
Attachment #8603509 -
Flags: approval-mozilla-aurora?
Backed out in https://hg.mozilla.org/integration/fx-team/rev/608aad7f1a11 for dt orange (along with bug 1160629): https://treeherder.mozilla.org/logviewer.html#?job_id=3007466&repo=fx-team
Flags: needinfo?(jaws)
Comment 5•9 years ago
|
||
The dt failures all look to be failures in the CSS parsability test, which is what bug 1160629 disabled. So I think this is good to reland (I didn't see any other obvious failures).
Updated•9 years ago
|
Flags: needinfo?(jaws)
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38.0.5:
--- → affected
status-firefox39:
--- → affected
Resolution: --- → FIXED
Comment 7•9 years ago
|
||
Comment on attachment 8603509 [details] [diff] [review] Patch (Required for Pocket / 38.0.5 release.)
Attachment #8603509 -
Flags: approval-mozilla-release?
Attachment #8603509 -
Flags: approval-mozilla-release+
Attachment #8603509 -
Flags: approval-mozilla-aurora?
Attachment #8603509 -
Flags: approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c994c6bb3abb https://hg.mozilla.org/releases/mozilla-release/rev/a1c5d7a6a784
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
QA Contact: andrei.vaida
Comment 9•9 years ago
|
||
During testing of this fix I've noticed that there 2 different messages for trying to sign-up to Pocket without an internet connection: Message 1: Unable to connect Firefox can't establish a connection to the server at getpocket.com. The site could be temporarily unavailable or too busy. Try again in a few moments. If you are unable to load any pages, check your computer's network connection. If your computer or network is protected by a firewall or proxy, make sure that Nightly is permitted to access the Web. Message 2: Server not found Firefox can't find the server at getpocket.com. Check the address for typing errors such as ww.example.com instead of www.example.com If you are unable to load any pages, check your computer's network connection. If your computer or network is protected by a firewall or proxy, make sure that Nightly is permitted to access the Web. The environment used is: FF 38.0.5 Build Id: 20150510205200 FF 40 Build Id:20150510030207 OS: Win 7 x64 Is this expected behavior it seems strange to offer 2 different error messages for the same issue? This is the link that is opened when trying to sign up to pocket with the Firefox Account: https://getpocket.com/ff_signup?s=hero&t=wlm
Flags: needinfo?(jaws)
Assignee | ||
Comment 10•9 years ago
|
||
The difference between these two errors is very small when the network disconnected. This is acceptable behavior.
Flags: needinfo?(jaws)
Comment 11•9 years ago
|
||
Confirmed fixed through the Regression testing performed on 38.0.5b1-build2 (20150511143336), using Windows 7 (x64), Windows 8.1 (x86), Mac OS X 10.9.5 and Ubuntu 14.04 (x64). All issues found were filed and will be treated separately.
You need to log in
before you can comment on or make changes to this bug.
Description
•