Closed Bug 1163192 Opened 5 years ago Closed 5 years ago

Remove usage of |#ifdef PR_LOGGING| from xslt

Categories

(Core :: XSLT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files)

In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603641 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Check that logging is enabled before performing potentially expensive
operations.
Attachment #8603642 - Flags: review?(nfroyd)
Comment on attachment 8603641 [details] [diff] [review]
Part 1: Remove instances of #ifdef PR_LOGGING in dom/xslt

Review of attachment 8603641 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xslt/base/txLog.h
@@ +20,5 @@
>      PRLogModuleInfo * txLog::xslt = 0;
>  
>  #define TX_LG_CREATE \
>      txLog::xpath = PR_NewLogModule("xpath"); \
>      txLog::xslt  = PR_NewLogModule("xslt")

Great moments in macros-as-C++-constructs.
Attachment #8603641 - Flags: review?(nfroyd) → review+
Attachment #8603642 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/1649cf3ead36
https://hg.mozilla.org/mozilla-central/rev/b8498d290c8a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.