1163192 - Remove usage of |#ifdef PR_LOGGING| from xslt

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Eric Rahm [:erahm]]

In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Part 1: Remove instances of #ifdef PR_LOGGING in dom/xslt

PR_LOGGING is now always defined, we can remove #ifdefs checking for it.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Part 2: Wrap expensive calls in PR_LOG_TEST

Check that logging is enabled before performing potentially expensive
operations.

Comment 3

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=128852820af5

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8603641 [details] [diff] [review]
Part 1: Remove instances of #ifdef PR_LOGGING in dom/xslt

Review of attachment 8603641 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xslt/base/txLog.h
@@ +20,5 @@
>      PRLogModuleInfo * txLog::xslt = 0;
>  
>  #define TX_LG_CREATE \
>      txLog::xpath = PR_NewLogModule("xpath"); \
>      txLog::xslt  = PR_NewLogModule("xslt")

Great moments in macros-as-C++-constructs.

Comment 5

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1649cf3ead36
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8498d290c8a

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1649cf3ead36
https://hg.mozilla.org/mozilla-central/rev/b8498d290c8a