Closed Bug 1163194 Opened 9 years ago Closed 9 years ago

Remove usage of |#ifdef PR_LOGGING| from dom/xul

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files, 1 obsolete file)

Part 1: Remove instances of #ifdef PR_LOGGING in dom/xul
55.01 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Part 2: Wrap expensive calls in PR_LOG_TEST
1.30 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603637 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603639 - Flags: review?(nfroyd)
Attachment #8603637 - Attachment is obsolete: true
Attachment #8603637 - Flags: review?(nfroyd)
Check that logging is enabled before performing potentially expensive
operations.
Attachment #8603640 - Flags: review?(nfroyd)
Attachment #8603639 - Flags: review?(nfroyd) → review+
Attachment #8603640 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/49ac06aeb3a8
https://hg.mozilla.org/mozilla-central/rev/3026a0345003
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: