Closed Bug 1163196 Opened 9 years ago Closed 9 years ago

Remove usage of |#ifdef PR_LOGGING| from dom/security

Categories

(Core :: DOM: Security, defect)

Product:
Core
Component:
DOM: Security
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files, 1 obsolete file)

Part 1: Remove instances of #ifdef PR_LOGGING in dom/security
17.01 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Part 2: Wrap expensive calls in PR_LOG_TEST
14.74 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603643 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8603644 - Flags: review?(nfroyd)
Attachment #8603643 - Attachment is obsolete: true
Attachment #8603643 - Flags: review?(nfroyd)
Check that logging is enabled before performing potentially expensive
operations.
Attachment #8603645 - Flags: review?(nfroyd)
Attachment #8603644 - Flags: review?(nfroyd) → review+
Comment on attachment 8603645 [details] [diff] [review]
Part 2:  Wrap expensive calls in PR_LOG_TEST

Review of attachment 8603645 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/security/nsCSPContext.cpp
@@ +51,5 @@
>    return gCspContextPRLog;
>  }
>  
>  #define CSPCONTEXTLOG(args) PR_LOG(GetCspContextLog(), 4, args)
> +#define CSPCONTEXTLOGENABLED() PR_LOG_TEST(GetCspContextLog(), 4)

Uh.  While we're here, can we replace '4' with the actual constant (PR_LOG_DEBUG, maybe?) ?  And so on throughout the patch.
Attachment #8603645 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #5)
> Comment on attachment 8603645 [details] [diff] [review]
> Part 2:  Wrap expensive calls in PR_LOG_TEST
> 
> Review of attachment 8603645 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/security/nsCSPContext.cpp
> @@ +51,5 @@
> >    return gCspContextPRLog;
> >  }
> >  
> >  #define CSPCONTEXTLOG(args) PR_LOG(GetCspContextLog(), 4, args)
> > +#define CSPCONTEXTLOGENABLED() PR_LOG_TEST(GetCspContextLog(), 4)
> 
> Uh.  While we're here, can we replace '4' with the actual constant
> (PR_LOG_DEBUG, maybe?) ?  And so on throughout the patch.

Hah, I was trying to avoid some blame :) I'll do a separate patch for that.
Actually I'll just update before I push, I thought this was a different offender.
https://hg.mozilla.org/mozilla-central/rev/e24aa2dd0e9a
https://hg.mozilla.org/mozilla-central/rev/f86c4ccf1d17
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.