1163196 - Remove usage of |#ifdef PR_LOGGING| from dom/security

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Eric Rahm [:erahm]]

In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Part 1: Remove instances of #ifdef PR_LOGGING in dom/security

PR_LOGGING is now always defined, we can remove #ifdefs checking for it.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Part 1: Remove instances of #ifdef PR_LOGGING in dom/security

PR_LOGGING is now always defined, we can remove #ifdefs checking for it.

Comment 3

[Eric Rahm [:erahm]]

Attachment: Part 2: Wrap expensive calls in PR_LOG_TEST

Check that logging is enabled before performing potentially expensive
operations.

Comment 4

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=128852820af5

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8603645 [details] [diff] [review]
Part 2:  Wrap expensive calls in PR_LOG_TEST

Review of attachment 8603645 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/security/nsCSPContext.cpp
@@ +51,5 @@
>    return gCspContextPRLog;
>  }
>  
>  #define CSPCONTEXTLOG(args) PR_LOG(GetCspContextLog(), 4, args)
> +#define CSPCONTEXTLOGENABLED() PR_LOG_TEST(GetCspContextLog(), 4)

Uh.  While we're here, can we replace '4' with the actual constant (PR_LOG_DEBUG, maybe?) ?  And so on throughout the patch.

Comment 6

[Eric Rahm [:erahm]]

(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #5)
> Comment on attachment 8603645 [details] [diff] [review]
> Part 2:  Wrap expensive calls in PR_LOG_TEST
> 
> Review of attachment 8603645 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/security/nsCSPContext.cpp
> @@ +51,5 @@
> >    return gCspContextPRLog;
> >  }
> >  
> >  #define CSPCONTEXTLOG(args) PR_LOG(GetCspContextLog(), 4, args)
> > +#define CSPCONTEXTLOGENABLED() PR_LOG_TEST(GetCspContextLog(), 4)
> 
> Uh.  While we're here, can we replace '4' with the actual constant
> (PR_LOG_DEBUG, maybe?) ?  And so on throughout the patch.

Hah, I was trying to avoid some blame :) I'll do a separate patch for that.

Comment 7

[Eric Rahm [:erahm]]

Actually I'll just update before I push, I thought this was a different offender.

Comment 8

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e24aa2dd0e9a
https://hg.mozilla.org/integration/mozilla-inbound/rev/f86c4ccf1d17

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e24aa2dd0e9a
https://hg.mozilla.org/mozilla-central/rev/f86c4ccf1d17