1163214 - Add a minimum version check for rustc

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

In addition to checking for the rust compiler's existence, we should check its version against some minimum in case people have old, pre-1.0 installs in their path.

from https://bugzilla.mozilla.org/show_bug.cgi?id=1161339#c22

Comment 1

[Simon Sapin (:SimonSapin)]

`rustc --version --verbose` gives each bit of information on a separate line, and so may be easier to parse. Example output on my system:

$ rustc --version
rustc 1.1.0-nightly (7bd71637c 2015-05-06) (built 2015-05-06)

$ rustc --version --verbose
rustc 1.1.0-nightly (7bd71637c 2015-05-06) (built 2015-05-06)
binary: rustc
commit-hash: 7bd71637ca40910dbd310813a19abf76db84f8f6
commit-date: 2015-05-06
build-date: 2015-05-06
host: x86_64-unknown-linux-gnu
release: 1.1.0-nightly

Comment 2

[Ralph Giles (:rillian)]

Thanks. Looks like the first line is still the same, but parsing the release line might be safer than parsing the single line?

Comment 3

[Simon Sapin (:SimonSapin)]

Right, the first line is the same. I don’t know what language these checks are written in, but if it’s something like bash this should work: `rustc -Vv|grep release:|cut -d' ' -f2`

Comment 4

[Ralph Giles (:rillian)]

Attachment: Align --enable-rust help text

Incidental fixup

Comment 5

[Ralph Giles (:rillian)]

(In reply to Simon Sapin (:SimonSapin) from comment #3)
> Right, the first line is the same. I don’t know what language these checks
> are written in, but if it’s something like bash this should work: `rustc
> -Vv|grep release:|cut -d' ' -f2`

Yep, that works. I don't see how it's more reliable than `rustc -V|cut -d' ' -f2` though?

The real difficulty is parsing and comparing semvers in bash. :/

Comment 6

[Ralph Giles (:rillian)]

Attachment: Add rustc minimum version check

How's this? We can add an additional clause to reject 1.0.0 pre-releases next week after the first stable release is published.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 8604737 [details] [diff] [review]
Add rustc minimum version check

Review of attachment 8604737 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +438,5 @@
> +  _RUSTC_MINOR_VERSION=`echo ${RUSTC_VERSION} | cut -d . -f 2`
> +  _RUSTC_EXTRA_VERSION=`echo ${RUSTC_VERSION} | cut -d . -f 3 | cut -d + -f 1`
> +  _RUSTC_PATCH_VERSION=`echo ${_RUSTC_EXTRA_VERSION} | cut -d '-' -f 1`
> +  _RUSTC_PRERELEASE_VERSION=`echo $_{RUSTC_EXTRA_VERSION} | cut -d '-' -f 2`
> +  _RUSTC_BUILD_VERSION=`echo ${RUSTC_VERSION} | cut -d . -f 3 | cut -d + -f 2`

I would say leave the extra/patch/prerelease/build bits out until we need them.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 8604340 [details] [diff] [review]
Align --enable-rust help text

Review of attachment 8604340 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me to fix formatting stuff like this without explicit review in the future.

Comment 9

[(not currently active) Ted Mielczarek]

Oh, sorry, I missed your comment there. If you want to add the "reject prereleases" stuff, then keep that in.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/399e3553eb7f
https://hg.mozilla.org/integration/mozilla-inbound/rev/611907765657

Comment 11

[Ralph Giles (:rillian)]

Thanks for the review. I removed the SUFFIX and BUILD variables for now. Post-1.0 rustc is using a train model, which will hopefully keep things regular enough we won't need more than the version number.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/399e3553eb7f
https://hg.mozilla.org/mozilla-central/rev/611907765657