Closed Bug 1163268 Opened 9 years ago Closed 9 years ago

Remove "Record Memory" and "JIT Optimizations" from the UI for the time being

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

37 Branch
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

This will still be accessible via pref, but memory has too many issues with it, and we do not have enough time until 40.1.

JIT Optimizations may as well be arcane runes for now.
Comment on attachment 8603687 [details] [diff] [review]
1163268-remove-memory-jit-options.patch

Review of attachment 8603687 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/performance.xul
@@ +41,4 @@
>                  type="checkbox"
>                  data-pref="enable-memory"
>                  label="&profilerUI.enableMemory;"
> +                tooltiptext="&profilerUI.enableMemory.tooltiptext;"/> -->

Bug no.

@@ +66,4 @@
>                  type="checkbox"
>                  data-pref="show-jit-optimizations"
>                  label="&profilerUI.showJITOptimizations;"
> +                tooltiptext="&profilerUI.showJITOptimizations.tooltiptext;"/> -->

Bug no.

::: browser/devtools/performance/views/toolbar.js
@@ +26,5 @@
>      // (details.js takes care of view buttons)
> +    //
> +    // TODO Removed "#option-enable-memory" and "#option-show-jit-optimizations"
> +    // in bug 1163268, to be re-enabled at a later point. At that point, should
> +    // put them back here.

Could comment them out instead of deleting them altogether. Nit: format the array so that there's one string per line, then comment out the two options.
Attachment #8603687 - Flags: review?(vporof) → review+
Updated, landed https://hg.mozilla.org/integration/fx-team/rev/2cc54ae7afa5
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2cc54ae7afa5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.