[SpotManager] Spot Requests not cancelled

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ekyle, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

3 years ago
From Lex,

> A failed instance request sticks around, if I understand 
> things correctly.  It'll have a status of "price-too-low" 
> until the price drops enough for the request to be fulfilled.  
> update_spot_requests() doesn't count a "price-too-low" 
> request against its budget.  So indeed, it will attempt 
> to submit more bids -- but it won't cancel the ones that 
> failed.  When the price drops, they'll be fulfilled, and we 
> might end up spending too much money.
(Reporter)

Updated

3 years ago
Assignee: klahnakoski → nobody
(Reporter)

Comment 1

2 years ago
Spot requests have a `expiration` (in the settings) to ensure requests do not stick around.

https://github.com/klahnakoski/SpotManager/blob/4da9e06e89ce90bc8d42f0c6c600ff642427e162/spot/spot_manager.py#L516
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.