"TypeError: getBrowser(...) is null" in contentAreaClick with Lightning installed and started in calendar view

RESOLVED FIXED in Thunderbird 40.0

Status

Thunderbird
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Tracking

({regression})

Trunk
Thunderbird 40.0
regression

Thunderbird Tracking Flags

(thunderbird38 fixed, thunderbird39 fixed, thunderbird40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Error: TypeError: getBrowser(...) is null
Source File: chrome://communicator/content/contentAreaClick.js
Line: 60

This messages is showing up 4 times, when TB is started with calendar view (task view: 5 time) to be shown at first. Tthe messages appear right after that one about the undefined tab from bug 1070630.

This seems to be a regression of bug 1139817.

Comment 1

3 years ago
So despite the trash talk, the reviewer in bug 1139817 was actually unfit for the job.  The original code specifically tested for getBrowser and that it had a contentDocument, as both may not exist (if one bothers to consider all the many cases).
(Assignee)

Comment 2

3 years ago
Created attachment 8603744 [details] [diff] [review]
ReimplementBrowserCheck-v1.diff

This patch reimplements the check on getBrowser.
Assignee: nobody → makemyday
Attachment #8603744 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED

Comment 3

3 years ago
Comment on attachment 8603744 [details] [diff] [review]
ReimplementBrowserCheck-v1.diff

Review of attachment 8603744 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #8603744 - Flags: review?(mkmelin+mozilla) → review+

Comment 4

3 years ago
https://hg.mozilla.org/comm-central/rev/38116ed2287c -> FIXED
Blocks: 1139817
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-thunderbird38: --- → unaffected
status-thunderbird39: --- → affected
Keywords: regression
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
(Assignee)

Comment 5

3 years ago
Thanks for review and checkin. Are you sure about TB38? I haven't cheked the beta, but codewise comm-beta is also affected.

Comment 6

3 years ago
AH bug 1139817 got uplifted so this is also needed for 38.
status-thunderbird38: unaffected → affected

Comment 7

3 years ago
Comment on attachment 8603744 [details] [diff] [review]
ReimplementBrowserCheck-v1.diff

Review of attachment 8603744 [details] [diff] [review]:
-----------------------------------------------------------------

Should uplift after trunk baking.
Attachment #8603744 - Flags: approval-comm-beta?
Attachment #8603744 - Flags: approval-comm-aurora?

Comment 8

3 years ago
Comment on attachment 8603744 [details] [diff] [review]
ReimplementBrowserCheck-v1.diff

(TB-39): http://hg.mozilla.org/releases/comm-beta/rev/1d17524e7d74
(TB-38): http://hg.mozilla.org/releases/comm-beta/rev/cfca7dcba68a
Attachment #8603744 - Flags: approval-comm-beta?
Attachment #8603744 - Flags: approval-comm-beta+
Attachment #8603744 - Flags: approval-comm-aurora?
Attachment #8603744 - Flags: approval-comm-aurora+

Updated

3 years ago
status-thunderbird38: affected → fixed
status-thunderbird39: affected → fixed
status-thunderbird40: --- → fixed
You need to log in before you can comment on or make changes to this bug.