Closed
Bug 1163299
Opened 9 years ago
Closed 9 years ago
"TypeError: getBrowser(...) is null" in contentAreaClick with Lightning installed and started in calendar view
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird38 fixed, thunderbird39 fixed, thunderbird40 fixed)
RESOLVED
FIXED
Thunderbird 40.0
People
(Reporter: MakeMyDay, Assigned: MakeMyDay)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.02 KB,
patch
|
mkmelin
:
review+
rkent
:
approval-comm-aurora+
rkent
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Error: TypeError: getBrowser(...) is null Source File: chrome://communicator/content/contentAreaClick.js Line: 60 This messages is showing up 4 times, when TB is started with calendar view (task view: 5 time) to be shown at first. Tthe messages appear right after that one about the undefined tab from bug 1070630. This seems to be a regression of bug 1139817.
So despite the trash talk, the reviewer in bug 1139817 was actually unfit for the job. The original code specifically tested for getBrowser and that it had a contentDocument, as both may not exist (if one bothers to consider all the many cases).
Assignee | ||
Comment 2•9 years ago
|
||
This patch reimplements the check on getBrowser.
Assignee: nobody → makemyday
Attachment #8603744 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
Comment on attachment 8603744 [details] [diff] [review] ReimplementBrowserCheck-v1.diff Review of attachment 8603744 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thx! r=mkmelin
Attachment #8603744 -
Flags: review?(mkmelin+mozilla) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/38116ed2287c -> FIXED
Blocks: 1139817
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-thunderbird38:
--- → unaffected
status-thunderbird39:
--- → affected
Keywords: regression
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Assignee | ||
Comment 5•9 years ago
|
||
Thanks for review and checkin. Are you sure about TB38? I haven't cheked the beta, but codewise comm-beta is also affected.
Comment 6•9 years ago
|
||
AH bug 1139817 got uplifted so this is also needed for 38.
Comment 7•9 years ago
|
||
Comment on attachment 8603744 [details] [diff] [review] ReimplementBrowserCheck-v1.diff Review of attachment 8603744 [details] [diff] [review]: ----------------------------------------------------------------- Should uplift after trunk baking.
Attachment #8603744 -
Flags: approval-comm-beta?
Attachment #8603744 -
Flags: approval-comm-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8603744 [details] [diff] [review] ReimplementBrowserCheck-v1.diff (TB-39): http://hg.mozilla.org/releases/comm-beta/rev/1d17524e7d74 (TB-38): http://hg.mozilla.org/releases/comm-beta/rev/cfca7dcba68a
Attachment #8603744 -
Flags: approval-comm-beta?
Attachment #8603744 -
Flags: approval-comm-beta+
Attachment #8603744 -
Flags: approval-comm-aurora?
Attachment #8603744 -
Flags: approval-comm-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•