Closed
Bug 1163306
Opened 9 years ago
Closed 9 years ago
Re-enable libical tests and disable ical.js in nightly builds when binary compatibility is back
Categories
(Calendar :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.2
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(2 files)
1.05 KB,
patch
|
ssitter
:
review+
ssitter
:
checkin+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
|
Details | Diff | Splinter Review |
In bug 1162300 we enabled ical.js for nightly builds and also disabled libical for the tests. We should revert this once binary compatibility is back.
Updated•9 years ago
|
OS: Unspecified → All
Hardware: Unspecified → All
Version: Trunk → Lightning 4.2
Comment 1•9 years ago
|
||
Do you know the bug # to add back support for extensions with binary XPCOM components in Thunderbird?
Assignee | ||
Comment 2•9 years ago
|
||
I haven't filed it yet, nor searched for one. The patch is almost ready though.
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/3318e9799d45 for re-enabling tests, we can switch back to libical once the tests pass.
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/857f3791ddf8 for re-enabling tests on aurora.
Comment 5•9 years ago
|
||
Will they run with libical when calendar.icaljs is set to true? Maybe we need something like head_icaljs.js for libical that will set calendar.icaljs to false before the test.
Assignee | ||
Comment 6•9 years ago
|
||
Something like this?
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 11•9 years ago
|
||
Comment on attachment 8608816 [details] [diff] [review] Force disable libical - v1 Looks good to me.
Attachment #8608816 -
Flags: review?(ssitter) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 13•9 years ago
|
||
Ok, lets hope it works: https://hg.mozilla.org/comm-central/rev/e74c3369238f
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 20•9 years ago
|
||
That worked very well. Pushing to aurora, where tests will work as soon as the binary extensions patch is backported to mozilla-aurora, which I also forgot. I hope its just a day or two, I think we can live with failing tests on aurora for that time. https://hg.mozilla.org/releases/comm-aurora/rev/d951b2a509b8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.2
Comment 21•9 years ago
|
||
Now that libical is working again we can revert the change from Bug 1162300 Attachment 8602947 [details] [diff] (enable icaljs by default) in comm-central.
Assignee | ||
Comment 22•9 years ago
|
||
What are your thoughts on keeping ical.js enabled on comm-central only, e.g protecting it with an ifdef? In the long run I'd like to move to ical.js and this would give us some extra testing. It would mean that issues specific to libical would only be caught on aurora, but I don't recall too many of those lately and I believe most issues are only caught on beta anyway.
Flags: needinfo?(ssitter)
Comment 23•9 years ago
|
||
Sure. Is there an existing flag/switch to differentiate comm-central from other branches?
Flags: needinfo?(ssitter)
Assignee | ||
Comment 24•9 years ago
|
||
Looking at http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#3532 it seems we can use NIGHTLY_BUILD. I thought that aurora has that set too, but it seems not. Alternatively there is MOZ_UPDATE_CHANNEL.
Comment 25•9 years ago
|
||
This patch changes the behavior and enables icaljs on only comm-central.
Attachment #8625048 -
Flags: review?(philipp)
Attachment #8625048 -
Flags: approval-calendar-aurora?(philipp)
Assignee | ||
Updated•9 years ago
|
Attachment #8625048 -
Flags: review?(philipp)
Attachment #8625048 -
Flags: review+
Attachment #8625048 -
Flags: approval-calendar-aurora?(philipp)
Attachment #8625048 -
Flags: approval-calendar-aurora+
Updated•9 years ago
|
Attachment #8608816 -
Flags: checkin+
Updated•9 years ago
|
Attachment #8625048 -
Attachment description: 1163306-icaljs-nightly-only.diff → enables icaljs only on comm-central
Updated•9 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin-needed comm-central, comm-aurora]
Assignee | ||
Comment 26•9 years ago
|
||
Pushed to comm-central changeset 99d02f70de9a
Keywords: checkin-needed
Target Milestone: 4.2 → 4.3
Assignee | ||
Comment 27•9 years ago
|
||
Backported to releases/comm-aurora changeset c836a5a3a3e6
Target Milestone: 4.3 → 4.2
Assignee | ||
Updated•9 years ago
|
Whiteboard: [checkin-needed comm-central, comm-aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•