In bug 1162300 we enabled ical.js for nightly builds and also disabled libical for the tests. We should revert this once binary compatibility is back.
Do you know the bug # to add back support for extensions with binary XPCOM components in Thunderbird?
I haven't filed it yet, nor searched for one. The patch is almost ready though.
https://hg.mozilla.org/comm-central/rev/3318e9799d45 for re-enabling tests, we can switch back to libical once the tests pass.
https://hg.mozilla.org/releases/comm-aurora/rev/857f3791ddf8 for re-enabling tests on aurora.
Will they run with libical when calendar.icaljs is set to true? Maybe we need something like head_icaljs.js for libical that will set calendar.icaljs to false before the test.
Created attachment 8608816 [details] [diff] [review] Force disable libical - v1 Something like this?
Comment on attachment 8608816 [details] [diff] [review] Force disable libical - v1 Looks good to me.
Ok, lets hope it works: https://hg.mozilla.org/comm-central/rev/e74c3369238f
That worked very well. Pushing to aurora, where tests will work as soon as the binary extensions patch is backported to mozilla-aurora, which I also forgot. I hope its just a day or two, I think we can live with failing tests on aurora for that time. https://hg.mozilla.org/releases/comm-aurora/rev/d951b2a509b8
Now that libical is working again we can revert the change from Bug 1162300 Attachment 8602947 [details] [diff] (enable icaljs by default) in comm-central.
What are your thoughts on keeping ical.js enabled on comm-central only, e.g protecting it with an ifdef? In the long run I'd like to move to ical.js and this would give us some extra testing. It would mean that issues specific to libical would only be caught on aurora, but I don't recall too many of those lately and I believe most issues are only caught on beta anyway.
Sure. Is there an existing flag/switch to differentiate comm-central from other branches?
Looking at http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#3532 it seems we can use NIGHTLY_BUILD. I thought that aurora has that set too, but it seems not. Alternatively there is MOZ_UPDATE_CHANNEL.
Created attachment 8625048 [details] [diff] [review] enables icaljs only on comm-central This patch changes the behavior and enables icaljs on only comm-central.
Pushed to comm-central changeset 99d02f70de9a
Backported to releases/comm-aurora changeset c836a5a3a3e6