The default bug view has changed. See this FAQ.

Re-enable libical tests and disable ical.js in nightly builds when binary compatibility is back

RESOLVED FIXED in 4.2

Status

Calendar
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Lightning 4.2
Dependency tree / graph

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
In bug 1162300 we enabled ical.js for nightly builds and also disabled libical for the tests. We should revert this once binary compatibility is back.
(Assignee)

Updated

2 years ago
Depends on: 1162300

Updated

2 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Version: Trunk → Lightning 4.2

Comment 1

2 years ago
Do you know the bug # to add back support for extensions with binary XPCOM components in Thunderbird?
(Assignee)

Comment 2

2 years ago
I haven't filed it yet, nor searched for one. The patch is almost ready though.
(Assignee)

Updated

2 years ago
Depends on: 1165428
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/comm-central/rev/3318e9799d45 for re-enabling tests, we can switch back to libical once the tests pass.
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/857f3791ddf8 for re-enabling tests on aurora.

Comment 5

2 years ago
Will they run with libical when calendar.icaljs is set to true? Maybe we need something like head_icaljs.js for libical that will set calendar.icaljs to false before the test.
(Assignee)

Comment 6

2 years ago
Created attachment 8608816 [details] [diff] [review]
Force disable libical - v1

Something like this?
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8608816 - Flags: review?(ssitter)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Comment 11

2 years ago
Comment on attachment 8608816 [details] [diff] [review]
Force disable libical - v1

Looks good to me.
Attachment #8608816 - Flags: review?(ssitter) → review+
Comment hidden (Treeherder Robot)
(Assignee)

Comment 13

2 years ago
Ok, lets hope it works: https://hg.mozilla.org/comm-central/rev/e74c3369238f
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 20

2 years ago
That worked very well. Pushing to aurora, where tests will work as soon as the binary extensions patch is backported to mozilla-aurora, which I also forgot. I hope its just a day or two, I think we can live with failing tests on aurora for that time.

https://hg.mozilla.org/releases/comm-aurora/rev/d951b2a509b8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.2

Comment 21

2 years ago
Now that libical is working again we can revert the change from Bug 1162300 Attachment 8602947 [details] [diff] (enable icaljs by default) in comm-central.
(Assignee)

Comment 22

2 years ago
What are your thoughts on keeping ical.js enabled on comm-central only, e.g protecting it with an ifdef? In the long run I'd like to move to ical.js and this would give us some extra testing. It would mean that issues specific to libical would only be caught on aurora, but I don't recall too many of those lately and I believe most issues are only caught on beta anyway.
Flags: needinfo?(ssitter)

Comment 23

2 years ago
Sure. Is there an existing flag/switch to differentiate comm-central from other branches?
Flags: needinfo?(ssitter)
(Assignee)

Comment 24

2 years ago
Looking at http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#3532 it seems we can use NIGHTLY_BUILD. I thought that aurora has that set too, but it seems not. Alternatively there is MOZ_UPDATE_CHANNEL.

Comment 25

2 years ago
Created attachment 8625048 [details] [diff] [review]
enables icaljs only on comm-central

This patch changes the behavior and enables icaljs on only comm-central.
Attachment #8625048 - Flags: review?(philipp)
Attachment #8625048 - Flags: approval-calendar-aurora?(philipp)
(Assignee)

Updated

2 years ago
Attachment #8625048 - Flags: review?(philipp)
Attachment #8625048 - Flags: review+
Attachment #8625048 - Flags: approval-calendar-aurora?(philipp)
Attachment #8625048 - Flags: approval-calendar-aurora+

Updated

2 years ago
Attachment #8608816 - Flags: checkin+

Updated

2 years ago
Attachment #8625048 - Attachment description: 1163306-icaljs-nightly-only.diff → enables icaljs only on comm-central

Updated

2 years ago
Keywords: checkin-needed
Whiteboard: [checkin-needed comm-central, comm-aurora]
(Assignee)

Comment 26

2 years ago
Pushed to comm-central changeset 99d02f70de9a
Keywords: checkin-needed
Target Milestone: 4.2 → 4.3
(Assignee)

Comment 27

2 years ago
Backported to releases/comm-aurora changeset c836a5a3a3e6
Target Milestone: 4.3 → 4.2
(Assignee)

Updated

2 years ago
Whiteboard: [checkin-needed comm-central, comm-aurora]
You need to log in before you can comment on or make changes to this bug.