User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0 Build ID: 20150509030210 Steps to reproduce: Open a bookmarks toolbar menu, and try to edit a bookmark's Properties | Location there. Actual results: The Location field is greyed out, its URI uneditable. One can select the field, arrow through and select in it, but editing is impossible. Expected results: The URI should be editable, and saved in its edited form, showing that data when next opened for edit. Name, tags, keywords and description are editable, and edits are saved.
This looks like a recurrence of my previous bookmarks-location bug.
This happens whether bookmark is accessed for edit directly from Bookmarks Toolbar, or via Star drop-down menu.
[Tracking Requested - why for this release]:
I can duplicate this error in Firefox nightly 40.0a1 (2015-05-09) 1. Go to Bookmarks > Bookmarks toolbar > Getting started bookmark 2. Right click > properties 3. Attempt to edit location value (not possible with backslash/delete) and its not possible.
uoops stupid typo, I put an unwanted "not" there... this._locationField.readOnly = !this.readOnly;
Created attachment 8604073 [details] [diff] [review] patch v1
This is NOT fixed as of updating to the 2015-05-12 41.0a1 nightly. A bookmark's URI Location field is STILL greyed out and uneditable.
(In reply to Helge Skjeveland from comment #10) > This is NOT fixed as of updating to the 2015-05-12 41.0a1 nightly. A > bookmark's URI Location field is STILL greyed out and uneditable. Nightly41.0a1 2015-05-12 does not include the fix yet. Maybe tomorrow Nightly nightly will include.
Let me know if 2015-05-13 Nightly has the fix for this, and I'll test & verify.
Download a hourly build if you are not patient.
3 years ago
Requesting an uplift to Firefox 40
Comment on attachment 8604073 [details] [diff] [review] patch v1 Approval Request Comment [Feature/regressing bug #]: bookmarks panel rewrite [User impact if declined]: user can't edit the location of bookmarks [Describe test coverage new/current, TreeHerder]: Nightly, manual testing [Risks and why]: low risk oneline typo fix [String/UUID change made/needed]: none
This is at least the second time we've broken this functionality this year. Does this use case have test coverage to prevent this from regressing yet again?
Verified fixed in 2015-05-13 41.0a1 Nightly, on Win 7SP1.
bug 1160326 is about having more tests in this area.
Comment on attachment 8604073 [details] [diff] [review] patch v1 Aurora+
3 years ago