Closed Bug 1163341 Opened 9 years ago Closed 9 years ago

Unable to edit location of a Bookmark

Categories

(Firefox :: Bookmarks & History, defect)

40 Branch
x86_64
Windows 7
defect
Not set
normal
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
40.3 - 11 May
Tracking Status
firefox39 --- unaffected
firefox40 + verified
firefox41 --- verified

People

(Reporter: cud, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150509030210

Steps to reproduce:

Open a bookmarks toolbar menu, and try to edit a bookmark's Properties  | Location there.


Actual results:

The Location field is greyed out, its URI uneditable. One can select the field, arrow through and select in it, but editing is impossible.


Expected results:

The URI should be editable, and saved in its edited form, showing that data when next opened for edit. Name, tags, keywords and description are editable, and edits are saved.
This looks like a recurrence of my previous bookmarks-location bug.
OS: Unspecified → Windows 7
Priority: -- → P1
Hardware: Unspecified → x86_64
This happens whether bookmark is accessed for edit directly from Bookmarks Toolbar, or via Star drop-down menu.
Component: Untriaged → Toolbars and Customization
[Tracking Requested - why for this release]:
Blocks: 1160864
Status: UNCONFIRMED → NEW
Component: Toolbars and Customization → Bookmarks & History
Ever confirmed: true
Keywords: regression
Flags: needinfo?(mak77)
Priority: P1 → --
Blocks: 1161882
I can duplicate this error in Firefox nightly 40.0a1 (2015-05-09)
1. Go to Bookmarks > Bookmarks toolbar > Getting started bookmark
2. Right click > properties 
3. Attempt to edit location value (not possible with backslash/delete) and its not possible.
uoops stupid typo, I put an unwanted "not" there...
this._locationField.readOnly = !this.readOnly;
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(mak77)
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Attached patch patch v1Splinter Review
Attachment #8604073 - Flags: review?(ttaubert)
Attachment #8604073 - Flags: review?(ttaubert) → review+
Iteration: --- → 40.3 - 11 May
https://hg.mozilla.org/mozilla-central/rev/f957d54d6a61
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
This is NOT fixed as of updating to the 2015-05-12 41.0a1 nightly. A bookmark's URI Location field is STILL greyed out and uneditable.
Status: RESOLVED → REOPENED
Flags: needinfo?(cud)
Resolution: FIXED → ---
(In reply to Helge Skjeveland from comment #10)
> This is NOT fixed as of updating to the 2015-05-12 41.0a1 nightly. A
> bookmark's URI Location field is STILL greyed out and uneditable.

Nightly41.0a1 2015-05-12 does not include the fix yet.

Maybe tomorrow Nightly nightly will include.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Let me know if 2015-05-13 Nightly has the fix for this, and I'll test & verify.
Flags: needinfo?(cud)
Comment on attachment 8604073 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: bookmarks panel rewrite
[User impact if declined]: user can't edit the location of bookmarks
[Describe test coverage new/current, TreeHerder]: Nightly, manual testing
[Risks and why]: low risk oneline typo fix
[String/UUID change made/needed]: none
Flags: needinfo?(mak77)
Attachment #8604073 - Flags: approval-mozilla-aurora?
Summary: Bookmark properties edit is broken again → Unable to edit location of a Bookmark
This is at least the second time we've broken this functionality this year. Does this use case have test coverage to prevent this from regressing yet again?
Flags: in-testsuite?
Verified fixed in 2015-05-13 41.0a1 Nightly, on Win 7SP1.
Status: RESOLVED → VERIFIED
bug 1160326 is about having more tests in this area.
Comment on attachment 8604073 [details] [diff] [review]
patch v1

Aurora+
Attachment #8604073 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.