Closed
Bug 1163356
Opened 9 years ago
Closed 9 years ago
Should have xpcshell tests for performance components
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
52.36 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Performance tools are built very modular, and we have many components that can and should be tested via xpcshell, rather than mochitests, mainly the PerformanceFront and RecordingModel, but also any of the recording utils, frame utils, tree models, conversion functions for older geckos, etc.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Assignee | ||
Comment 1•9 years ago
|
||
I wonder if these are called on try if enabling xpcshell tests? https://treeherder.mozilla.org/#/jobs?repo=try&revision=730a6bbebad6
Attachment #8613244 -
Flags: review?(vporof)
Updated•9 years ago
|
Attachment #8613244 -
Flags: review?(vporof) → review+
Comment 2•9 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #0) > Performance tools are built very modular WE GOOD PRORAMMER
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9ede7775a177
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ede7775a177
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•