Closed
Bug 1163358
Opened 7 years ago
Closed 7 years ago
Add "psm" tag to PSM xpcshell and mochitest manifests
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
Attachments
(1 file)
3.53 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
See https://groups.google.com/forum/#!topic/mozilla.dev.platform/-LvCgfiKtJ0. Adding the tag at least makes running xpcshell tests and mochitests locally slightly easier, e.g.: > ./mach xpcshell-test --tag psm instead of: > ./mach xpcshell-test security/manager/ssl/tests/unit/ Hopefully the planned feature enhancements to this feature will be useful to PSM developers/testers as well. If not, adding the tags is at worst a no-op.
![]() |
Assignee | |
Comment 1•7 years ago
|
||
I can push this patch (and future ones) to MozReview as well if you prefer.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Attachment #8603781 -
Flags: review?(dkeeler)
Comment on attachment 8603781 [details] [diff] [review] bug1163358_add-psm-tag-test-manifests_v1.patch Review of attachment 8603781 [details] [diff] [review]: ----------------------------------------------------------------- Cool. I assume not tagging security/manager/ssl/tests/mochitest/mixedcontent/mochitest.ini was deliberate since that's sort-of-not-really PSM code?
Attachment #8603781 -
Flags: review?(dkeeler) → review+
(In reply to Cykesiopka from comment #1) > Created attachment 8603781 [details] [diff] [review] > bug1163358_add-psm-tag-test-manifests_v1.patch > > I can push this patch (and future ones) to MozReview as well if you prefer. I think for small patches using the review tool in bugzilla is fine. For larger patches, let's move more towards MozReview.
![]() |
Assignee | |
Comment 4•7 years ago
|
||
(In reply to David Keeler [:keeler] (use needinfo?) from comment #2) > Cool. I assume not tagging > security/manager/ssl/tests/mochitest/mixedcontent/mochitest.ini was > deliberate since that's sort-of-not-really PSM code? Yup. (In reply to David Keeler [:keeler] (use needinfo?) from comment #3) > I think for small patches using the review tool in bugzilla is fine. For > larger patches, let's move more towards MozReview. Sure.
![]() |
Assignee | |
Comment 5•7 years ago
|
||
Thanks for the review. (The patch just involves adding a tag to various manifests - I don't think a try push is really necessary, but I can still do one if preferred).
Keywords: checkin-needed
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03b10fccd3d8
Keywords: checkin-needed
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03b10fccd3d8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•