1163358 - Add "psm" tag to PSM xpcshell and mochitest manifests

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

See https://groups.google.com/forum/#!topic/mozilla.dev.platform/-LvCgfiKtJ0.

Adding the tag at least makes running xpcshell tests and mochitests locally slightly easier, e.g.:
> ./mach xpcshell-test --tag psm
instead of:
> ./mach xpcshell-test security/manager/ssl/tests/unit/

Hopefully the planned feature enhancements to this feature will be useful to PSM developers/testers as well. If not, adding the tags is at worst a no-op.

Comment 1

[:Cykesiopka]

Attachment: bug1163358_add-psm-tag-test-manifests_v1.patch

I can push this patch (and future ones) to MozReview as well if you prefer.

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8603781 [details] [diff] [review]
bug1163358_add-psm-tag-test-manifests_v1.patch

Review of attachment 8603781 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. I assume not tagging security/manager/ssl/tests/mochitest/mixedcontent/mochitest.ini was deliberate since that's sort-of-not-really PSM code?

Comment 3

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

(In reply to Cykesiopka from comment #1)
> Created attachment 8603781 [details] [diff] [review]
> bug1163358_add-psm-tag-test-manifests_v1.patch
> 
> I can push this patch (and future ones) to MozReview as well if you prefer.

I think for small patches using the review tool in bugzilla is fine. For larger patches, let's move more towards MozReview.

Comment 4

[:Cykesiopka]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> Cool. I assume not tagging
> security/manager/ssl/tests/mochitest/mixedcontent/mochitest.ini was
> deliberate since that's sort-of-not-really PSM code?

Yup.

(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> I think for small patches using the review tool in bugzilla is fine. For
> larger patches, let's move more towards MozReview.

Sure.

Comment 5

[:Cykesiopka]

Thanks for the review.

(The patch just involves adding a tag to various manifests - I don't think a try push is really necessary, but I can still do one if preferred).

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03b10fccd3d8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03b10fccd3d8

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03b10fccd3d8