1163397 - mozilla::PaintedLayerData can't be stored safely in an nsTArray because of the mLog member

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(no longer active)]

This is caught by the analysis I wrote for bug 1159433:

 0:57.83 /Users/ehsan/moz/src/layout/base/FrameLayerBuilder.cpp:694:3: error: Cannot instantiate 'nsTArray' with non-memmovable template argument 'mozilla::PaintedLayerData'
 0:57.83   nsTArray<PaintedLayerData> mPaintedLayerDataStack;
 0:57.83   ^
 0:57.83 ../../dist/include/nsTArray.h:1831:1: note: 'nsTArray' declared here
 0:57.83 class MOZ_NEEDS_MEMMOVABLE_TYPE nsTArray : public nsTArray_Impl<E, nsTArrayInfallibleAllocator>
 0:57.83 ^
 0:57.83 /Users/ehsan/moz/src/layout/base/FrameLayerBuilder.cpp:310:3: note: 'nsTArray' Cannot accept classes that are marked as non-memmovable as template argument because of this declaration
 0:57.83   nsAutoCString mLog;
 0:57.83   ^

nsAutoCString cannot safely be memmoved, and nsTArray does require its template argument to be memmovable because it memmoves the data stored in it when it reallocates its internal buffer.

Comment 1

[(no longer active)]

Attachment: Convert PaintedLayerData::mLog to an nsCString in order to make it possible to safely store PaintedLayerData inside nsTArrays

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a3db6682e0

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c6a3db6682e0