Closed Bug 1163411 Opened 5 years ago Closed 5 years ago

Update View Pocket Menu Link

Categories

(Firefox :: Pocket, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: nweiner, Assigned: nweiner)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch listPath.diff (obsolete) — Splinter Review
Updating the URL that "View Pocket List" in the bookmarks menu links to so that we can detect it and provide a specific experience for Firefox users as needed.

Just added "?src=ff_ext" to the end of the URL.

Note: This is my first attempt at submitting a patch, so feedback welcome if I should process this differently.
Attachment #8603846 - Flags: review?(dolske)
Comment on attachment 8603846 [details] [diff] [review]
listPath.diff

Review of attachment 8603846 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/pocket/Pocket.jsm
@@ +15,5 @@
>    "resource://gre/modules/ReaderMode.jsm");
>  
>  let Pocket = {
>    get site() Services.prefs.getCharPref("browser.pocket.site"),
> +  get listURL() { return "https://" + Pocket.site + "?src=ff_ext"; },

Pocket.site is getpocket.com, so this is creating https://getpocket.com?src=ff_ext which appears to work but I'm used to seeing a slash after the TLD and before the question mark.
Attached patch listPathv2.patchSplinter Review
Updated the link to include a slash per Jared's recommendation.
Attachment #8603846 - Attachment is obsolete: true
Attachment #8603846 - Flags: review?(dolske)
Attachment #8604183 - Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8604183 [details] [diff] [review]
listPathv2.patch

[Triage Comment]

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604183 - Flags: approval-mozilla-release+
Attachment #8604183 - Flags: approval-mozilla-beta+
Attachment #8604183 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/02ce92d55ac0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.