Closed
Bug 1163411
Opened 9 years ago
Closed 9 years ago
Update View Pocket Menu Link
Categories
(Firefox :: Pocket, defect)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
Firefox 41
People
(Reporter: nate+bugzilla, Assigned: nate+bugzilla)
Details
Attachments
(1 file, 1 obsolete file)
964 bytes,
patch
|
Dolske
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-beta+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
Updating the URL that "View Pocket List" in the bookmarks menu links to so that we can detect it and provide a specific experience for Firefox users as needed. Just added "?src=ff_ext" to the end of the URL. Note: This is my first attempt at submitting a patch, so feedback welcome if I should process this differently.
Attachment #8603846 -
Flags: review?(dolske)
Comment 1•9 years ago
|
||
Comment on attachment 8603846 [details] [diff] [review] listPath.diff Review of attachment 8603846 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/pocket/Pocket.jsm @@ +15,5 @@ > "resource://gre/modules/ReaderMode.jsm"); > > let Pocket = { > get site() Services.prefs.getCharPref("browser.pocket.site"), > + get listURL() { return "https://" + Pocket.site + "?src=ff_ext"; }, Pocket.site is getpocket.com, so this is creating https://getpocket.com?src=ff_ext which appears to work but I'm used to seeing a slash after the TLD and before the question mark.
Assignee | ||
Comment 2•9 years ago
|
||
Updated the link to include a slash per Jared's recommendation.
Attachment #8603846 -
Attachment is obsolete: true
Attachment #8603846 -
Flags: review?(dolske)
Updated•9 years ago
|
Attachment #8604183 -
Flags: review+
Updated•9 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•9 years ago
|
||
Comment on attachment 8604183 [details] [diff] [review] listPathv2.patch [Triage Comment] a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604183 -
Flags: approval-mozilla-release+
Attachment #8604183 -
Flags: approval-mozilla-beta+
Attachment #8604183 -
Flags: approval-mozilla-aurora+
Comment 5•9 years ago
|
||
(aurora currently closed) https://hg.mozilla.org/releases/mozilla-beta/rev/0bc611ce7c85 https://hg.mozilla.org/releases/mozilla-release/rev/9a7a198e1b06
Assignee: nobody → nate
status-firefox38.0.5:
--- → fixed
status-firefox39:
--- → fixed
status-firefox40:
--- → affected
https://hg.mozilla.org/mozilla-central/rev/02ce92d55ac0
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•