Closed
Bug 1163418
Opened 10 years ago
Closed 9 years ago
Intermittent e10s browser_CTP_iframe.js,browser_CTP_nonplugins.js,browser_CTP_resize.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/plugins/head.js:106 - Error: Timed out while waiting for a 'load'' event
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(e10s+, firefox48 fixed, firefox49 fixed, firefox-esr38 unaffected, firefox-esr45 wontfix, firefox50 fixed)
RESOLVED
FIXED
mozilla50
People
(Reporter: philor, Assigned: mrbkap)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(3 files, 1 obsolete file)
1.38 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
4.77 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
5.15 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•9 years ago
|
status-firefox41:
--- → affected
status-firefox42:
--- → affected
status-firefox-esr38:
--- → unaffected
Summary: Intermittent e10s browser_CTP_nonplugins.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/plugins/head.js:106 - Error: Timed out while waiting for a 'load'' event → Intermittent e10s browser_CTP_iframe.js,browser_CTP_nonplugins.js,browser_CTP_resize.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/plugins/head.js:106 - Error: Timed out while waiting for a 'load'' event
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 18•9 years ago
|
||
This test had its own version of waitForContentEvent that hadn't be converted to use BrowserTestUtils & friends. In order to preserve the original condition, I split it up into a ContentTask/ContentTaskUtils.waitForEvent.
Attachment #8761846 -
Flags: review?(felipc)
Assignee | ||
Comment 19•9 years ago
|
||
While I was looking for bugs like this, I found a couple more cases.
Attachment #8761847 -
Flags: review?(felipc)
Assignee | ||
Comment 20•9 years ago
|
||
These need to wait on an untrusted event. It's also important to capturing for the event, since it doesn't bubble.
Attachment #8761849 -
Flags: review?(felipc)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mrbkap
Assignee | ||
Comment 21•9 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 23•9 years ago
|
||
There was another CPOW hiding in this test.
Assignee | ||
Updated•9 years ago
|
Attachment #8761846 -
Attachment is obsolete: true
Attachment #8761846 -
Flags: review?(felipc)
Assignee | ||
Updated•9 years ago
|
Attachment #8763199 -
Flags: review?(felipc)
Assignee | ||
Comment 24•9 years ago
|
||
Updated•9 years ago
|
Attachment #8761847 -
Flags: review?(felipc) → review+
Comment 25•9 years ago
|
||
Comment on attachment 8761849 [details] [diff] [review]
Patch 3
Review of attachment 8761849 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/mochitest/BrowserTestUtils/ContentTaskUtils.jsm
@@ +96,5 @@
> *
> * @returns {Promise}
> * @resolves The Event object.
> */
> + waitForEvent(subject, eventName, capture, checkFn, wantsUntrusted = false) {
I couldn't find where this new argument is used. The other change in this patch uses the waitForContentEvent function, not waitForEvent. r+ if I'm missing something obvious
Attachment #8761849 -
Flags: review?(felipc) → review+
Updated•9 years ago
|
Attachment #8763199 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 26•9 years ago
|
||
(In reply to :Felipe Gomes (needinfo me!) [offline until Jun 24] from comment #25)
> I couldn't find where this new argument is used. The other change in this
> patch uses the waitForContentEvent function, not waitForEvent. r+ if I'm
> missing something obvious
You're not missing anything. A previous version of my patch did use this function before I simplified it to use waitForContentEvent and I decided to leave this change in as it could be useful to others in the future who do want to listen for untrusted events in a content task. I'm going to check it in as-is.
Comment 27•9 years ago
|
||
Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1af601a50b
Remove use of CPOWs in in browser plugin tests. r=felipe
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d54710a9a96
Remove use of CPOWs in browser_bookmark_titles.js. r=felipe
https://hg.mozilla.org/integration/mozilla-inbound/rev/42753a079c66
Remove use of CPOWs in safebrowsing tests. r=felipe
Comment 28•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e1af601a50b
https://hg.mozilla.org/mozilla-central/rev/4d54710a9a96
https://hg.mozilla.org/mozilla-central/rev/42753a079c66
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment hidden (Intermittent Failures Robot) |
Updated•9 years ago
|
status-firefox40:
wontfix → ---
status-firefox41:
affected → ---
status-firefox42:
affected → ---
status-firefox48:
--- → affected
status-firefox49:
--- → affected
status-firefox-esr45:
--- → wontfix
Whiteboard: [checkin-needed-aurora]
Comment 30•9 years ago
|
||
bugherder uplift |
Comment 31•9 years ago
|
||
bugherder uplift |
Updated•9 years ago
|
Whiteboard: [checkin-needed-aurora]
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•