1163419 - nsQtNetworkLinkService is reference-counted class but has a public destructor

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Piotr Tworek]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150427212337

Steps to reproduce:

Try to build gecko 40 with EmbedLite for SailfishOS / NemoMobile (https://github.com/tmeshkova/gecko-dev).


Actual results:

nsQtNetworkLinkService.cpp fails to compile due to a static assertion:

/home/tworaz/devel/sailfish-browser-workspace-next.git/gecko-dev/netwerk/system/qt/nsQtNetworkLinkService.cpp: In member function ‘virtual MozExternalRefCountType nsQtNetworkLinkService::AddRef()’:
/home/tworaz/devel/sailfish-browser-workspace-next.git/gecko-dev/netwerk/system/qt/nsQtNetworkLinkService.cpp:14:64: error: static assertion failed: Reference-counted class nsQtNetworkLinkService should not have a public destructo
r. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it.
NS_IMPL_ISUPPORTS(nsQtNetworkLinkService,


Expected results:

The code should compile without triggering any static asserts.

Comment 1

[Piotr Tworek]

Attachment: 0002-Make-nsQtNetworkLinkService-destructor-private.patch

Comment 2

[Piotr Tworek]

Attachment: 0001-Make-nsQtNetworkLinkService-destructor-private.patch

Updated commit message to comply with Mozilla commit message conventions.

Comment 3

[Piotr Tworek]

Attachment: 0001-Make-nsQtNetworkLinkService-destructor-private.patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8605385 [details] [diff] [review]
0001-Make-nsQtNetworkLinkService-destructor-private.patch

For future reference, using the checkin-needed bug keyword is the preferred way to request that somebody land your patch for you. It'll speed things up :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c6ab008844a

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5c6ab008844a