Closed Bug 1163419 Opened 7 years ago Closed 7 years ago

nsQtNetworkLinkService is reference-counted class but has a public destructor

Categories

(Firefox Build System :: General, defect)

40 Branch
ARM
Linux
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: tworaz666, Unassigned)

Details

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150427212337

Steps to reproduce:

Try to build gecko 40 with EmbedLite for SailfishOS / NemoMobile (https://github.com/tmeshkova/gecko-dev).


Actual results:

nsQtNetworkLinkService.cpp fails to compile due to a static assertion:

/home/tworaz/devel/sailfish-browser-workspace-next.git/gecko-dev/netwerk/system/qt/nsQtNetworkLinkService.cpp: In member function ‘virtual MozExternalRefCountType nsQtNetworkLinkService::AddRef()’:
/home/tworaz/devel/sailfish-browser-workspace-next.git/gecko-dev/netwerk/system/qt/nsQtNetworkLinkService.cpp:14:64: error: static assertion failed: Reference-counted class nsQtNetworkLinkService should not have a public destructo
r. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it.
NS_IMPL_ISUPPORTS(nsQtNetworkLinkService,


Expected results:

The code should compile without triggering any static asserts.
Attachment #8603858 - Flags: review?(dougt)
OS: Unspecified → Linux
Hardware: Unspecified → ARM
Attachment #8603858 - Flags: review?(dougt) → review+
Updated commit message to comply with Mozilla commit message conventions.
Attachment #8605381 - Attachment is obsolete: true
Attachment #8603858 - Attachment is obsolete: true
Attachment #8605385 - Flags: checkin?(dougt)
Comment on attachment 8605385 [details] [diff] [review]
0001-Make-nsQtNetworkLinkService-destructor-private.patch

For future reference, using the checkin-needed bug keyword is the preferred way to request that somebody land your patch for you. It'll speed things up :)
Attachment #8605385 - Flags: checkin?(dougt) → checkin+
https://hg.mozilla.org/mozilla-central/rev/5c6ab008844a
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.