Closed Bug 1163459 Opened 7 years ago Closed 7 years ago

[Gaia-Raptor] Make "runners" in Suite customizable

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(3 files)

Current runners in gaia-raptor is hard-coded. However, by design it is able and should to be customizable. For example, for integrating Marionette with Raptor, we need a new runner to prevent improper rebooting (since Marionette would receive no socket commands in such case).
Attached file Patch
The modifications are only add one option to register new phase with path. If the path is invalid, it would try to require it from the built-in ones. If it still fails, throw exception as the current version.
Attachment #8603976 - Flags: review?(eperelman)
Assignee: nobody → gweng
Comment on attachment 8603976 [details] [review]
Patch

Please re-request review with nits addressed.
Attachment #8603976 - Flags: review?(eperelman)
Comment on attachment 8603976 [details] [review]
Patch

Hi Eli, I've fixed what you addressed. And for the last line issue I'm not sure what's happened. Also, I think from the GitHub comment the original line has some 'No newline at the end of file' issue, so I don't know if it's correct and I should re-correct it again.
Attachment #8603976 - Flags: review?(eperelman)
Attachment #8603976 - Flags: review?(eperelman) → review+
Comment on attachment 8604669 [details] [review]
[gaia-node-modules] eliperelman:bug-1163459 > mozilla-b2g:master

Carrying over r+ for package bump.
Attachment #8604669 - Flags: review+
Comment on attachment 8604673 [details] [review]
[gaia] eliperelman:bug-1163459 > mozilla-b2g:master

Carrying over r+ for package bump.
Attachment #8604673 - Flags: review+
In master: https://github.com/mozilla-b2g/gaia/commit/f0fc93d9b3db93c4fd0b6062366e3b1ec4349d25
In npm: gaia-raptor@1.6.0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.