1163460 - add more options to marionette loader to support tests not under apps/ folder

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

While writing integration tests for TV, we may need to use marionette loader to load helper class. But the apps/ folder name is hard-coded in marionette loader which makes us unable to use it.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] huchengtw-moz:bug-1163460-add-options-to-marionette-loader > mozilla-b2g:master

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8604537 [details] [review]
[gaia] huchengtw-moz:bug-1163460-add-options-to-marionette-loader > mozilla-b2g:master

Kevin,

Since this file is created by you, may you review this patch?

I had added another option, baseFolder, to marionette.loader to let us load files inside of tv_apps.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8604537 [details] [review]
[gaia] huchengtw-moz:bug-1163460-add-options-to-marionette-loader > mozilla-b2g:master

I would prefer to not land this change since I thought that we were merging the system apps, but if that's not going to happen for a long time and this would help, I guess it's fine to do so. Thanks.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thanks Kevin.

But we still need this patch even if we merged these two system apps. Other apps under tv_apps still need it.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8e0e79bab7ecf9be3bb3f0a5881431924bd63a63