Closed
Bug 1163466
Opened 10 years ago
Closed 10 years ago
Fix jshint in smart-system
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chens, Assigned: chens)
References
Details
Attachments
(1 file)
We got jshint error in smart-system: tv_apps/smart-system/js/external_storage_monitor.js: line 2, col 1, 'Notification' is defined but never used. (ERROR)
Have to fix this before enable jshint for tv_apps on treeherder
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8603927 -
Flags: review?(im)
Comment hidden (obsolete) |
Comment 3•10 years ago
|
||
Comment on attachment 8603927 [details] [review]
[gaia] shamenchens:Bug1163466-jshint-smart-system > mozilla-b2g:master
LGTM.
Strange. We had fixed all of them before. Why we have this issue?
Attachment #8603927 -
Flags: review?(im) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/7e7fb93a334204415b1cf2a0bdd29c2d6065b99c
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•