1163497 - Remove MediaDecoder::OutputStreams()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

By moving stream connection/disconnection code to DecodedStream, we can remove MediaDecoder::OutputStreams().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=487b04c73bb8

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Fix build error. Try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=443a9f38dc7b

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1163497_part1_move_ConnectDecodedStreamToOutputStream-v1.patch

Part 1 - extract MediaDecoder::ConnectDecodedStreamToOutputStream() to DecodedStream::Connect().

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1163497_part2_remove_DestroyDecodedStream-v1.patch

Part 2 - Move MediaDecoder::DestroyDecodedStream() into DecodedStream::DestroyData().

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1163497_part3_move_stream_connection_code-v1.patch

Part 3 - move stream connection code from MediaDecoder::RecreateDecodedStream() to DecodedStream::RecreateData().

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1163497_part4_move_AddOutputStream_code-v1.patch

Part 4 - move output stream code from MediaDecoder::AddOutputStream() to DecodedStream::Connect().

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1163497_part5_remove_unused_functions-v1.patch

Part 5 - remove unused functions.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8609934 [details] [diff] [review]
1163497_part5_remove_unused_functions-v1.patch

Review of attachment 8609934 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/DecodedStream.cpp
@@ -158,5 @@
>    DecodedStream* mDecodedStream;
>    nsRefPtr<MediaStream> mStream;
>  };
>  
> -OutputStreamData::OutputStreamData()

Since all stream connection/disconnection code is moved to DecodedStream.cpp, |OutputStreamData* os = OutputStreams().AppendElement()| in DecodedStream::Connect() sees the complete definition of OutputStreamData when instantiating the template. We don't need to provide our own constructor anymore.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f79a3159a09d
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbf69c6aef56
https://hg.mozilla.org/integration/mozilla-inbound/rev/085e8e8b0a34
https://hg.mozilla.org/integration/mozilla-inbound/rev/2252ecf505ea
https://hg.mozilla.org/integration/mozilla-inbound/rev/20b649df52a6

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f79a3159a09d
https://hg.mozilla.org/mozilla-central/rev/cbf69c6aef56
https://hg.mozilla.org/mozilla-central/rev/085e8e8b0a34
https://hg.mozilla.org/mozilla-central/rev/2252ecf505ea
https://hg.mozilla.org/mozilla-central/rev/20b649df52a6