Closed Bug 1163497 Opened 9 years ago Closed 9 years ago

Remove MediaDecoder::OutputStreams()

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

By moving stream connection/disconnection code to DecodedStream, we can remove MediaDecoder::OutputStreams().
Blocks: 1163467
Depends on: 1163489
Part 1 - extract MediaDecoder::ConnectDecodedStreamToOutputStream() to DecodedStream::Connect().
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8609929 - Flags: review?(roc)
Part 2 - Move MediaDecoder::DestroyDecodedStream() into DecodedStream::DestroyData().
Attachment #8609930 - Flags: review?(roc)
Part 3 - move stream connection code from MediaDecoder::RecreateDecodedStream() to DecodedStream::RecreateData().
Attachment #8609931 - Flags: review?(roc)
Part 4 - move output stream code from MediaDecoder::AddOutputStream() to DecodedStream::Connect().
Attachment #8609932 - Flags: review?(roc)
Part 5 - remove unused functions.
Comment on attachment 8609934 [details] [diff] [review]
1163497_part5_remove_unused_functions-v1.patch

Review of attachment 8609934 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/DecodedStream.cpp
@@ -158,5 @@
>    DecodedStream* mDecodedStream;
>    nsRefPtr<MediaStream> mStream;
>  };
>  
> -OutputStreamData::OutputStreamData()

Since all stream connection/disconnection code is moved to DecodedStream.cpp, |OutputStreamData* os = OutputStreams().AppendElement()| in DecodedStream::Connect() sees the complete definition of OutputStreamData when instantiating the template. We don't need to provide our own constructor anymore.
Attachment #8609934 - Flags: review?(roc)
Thanks for the review.
You need to log in before you can comment on or make changes to this bug.