Remove MediaDecoder::OutputStreams()

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(5 attachments)

(Assignee)

Description

4 years ago
By moving stream connection/disconnection code to DecodedStream, we can remove MediaDecoder::OutputStreams().
(Assignee)

Updated

4 years ago
Blocks: 1163467
Depends on: 1163489
(Assignee)

Comment 3

4 years ago
Created attachment 8609929 [details] [diff] [review]
1163497_part1_move_ConnectDecodedStreamToOutputStream-v1.patch

Part 1 - extract MediaDecoder::ConnectDecodedStreamToOutputStream() to DecodedStream::Connect().
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8609929 - Flags: review?(roc)
(Assignee)

Comment 4

4 years ago
Created attachment 8609930 [details] [diff] [review]
1163497_part2_remove_DestroyDecodedStream-v1.patch

Part 2 - Move MediaDecoder::DestroyDecodedStream() into DecodedStream::DestroyData().
Attachment #8609930 - Flags: review?(roc)
(Assignee)

Comment 5

4 years ago
Created attachment 8609931 [details] [diff] [review]
1163497_part3_move_stream_connection_code-v1.patch

Part 3 - move stream connection code from MediaDecoder::RecreateDecodedStream() to DecodedStream::RecreateData().
Attachment #8609931 - Flags: review?(roc)
(Assignee)

Comment 6

4 years ago
Created attachment 8609932 [details] [diff] [review]
1163497_part4_move_AddOutputStream_code-v1.patch

Part 4 - move output stream code from MediaDecoder::AddOutputStream() to DecodedStream::Connect().
Attachment #8609932 - Flags: review?(roc)
(Assignee)

Comment 7

4 years ago
Created attachment 8609934 [details] [diff] [review]
1163497_part5_remove_unused_functions-v1.patch

Part 5 - remove unused functions.
(Assignee)

Comment 8

4 years ago
Comment on attachment 8609934 [details] [diff] [review]
1163497_part5_remove_unused_functions-v1.patch

Review of attachment 8609934 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/DecodedStream.cpp
@@ -158,5 @@
>    DecodedStream* mDecodedStream;
>    nsRefPtr<MediaStream> mStream;
>  };
>  
> -OutputStreamData::OutputStreamData()

Since all stream connection/disconnection code is moved to DecodedStream.cpp, |OutputStreamData* os = OutputStreams().AppendElement()| in DecodedStream::Connect() sees the complete definition of OutputStreamData when instantiating the template. We don't need to provide our own constructor anymore.
Attachment #8609934 - Flags: review?(roc)
(Assignee)

Comment 9

4 years ago
Thanks for the review.
You need to log in before you can comment on or make changes to this bug.