Closed Bug 1163506 Opened 9 years ago Closed 9 years ago

[Stingray] Display time & date on dashboard

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S1 (26Jun)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: yifan, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] begeeben:1163506_display_time > mozilla-b2g:master
46 bytes, text/x-github-pull-request
johnhu
: review+
rexboy
: review+
Details | Review 
Display time & date at the center of the dashboard.
Assignee: nobody → rexboy
Assignee: rexboy → yliao
Comment on attachment 8611090 [details] [review]
[gaia] begeeben:1163506_display_time > mozilla-b2g:master

Please help review this PR, thanks!

* Display date & time;
* Fix background image repeated bug.
* Remove panel colors.
Attachment #8611090 - Flags: review?(rexboy)
Attachment #8611090 - Flags: review?(im)
Comment on attachment 8611090 [details] [review]
[gaia] begeeben:1163506_display_time > mozilla-b2g:master

looks good to me. Please file another bug to have more accurate tick on second digital.
Attachment #8611090 - Flags: review?(im) → review+
Blocks: 1169137
Comment on attachment 8611090 [details] [review]
[gaia] begeeben:1163506_display_time > mozilla-b2g:master

Looks fine but I have some questions there. You can try to fix it and feel free to discuss with me.
Thank you!
Attachment #8611090 - Flags: review?(rexboy) → review+
Comment on attachment 8611090 [details] [review]
[gaia] begeeben:1163506_display_time > mozilla-b2g:master

* Use l10nArgs to support different date syntax of different languages.
* Revised test according to nits and l10nArgs.
Attachment #8611090 - Flags: review?(rexboy)
Attachment #8611090 - Flags: review?(im)
Attachment #8611090 - Flags: review+
Comment on attachment 8611090 [details] [review]
[gaia] begeeben:1163506_display_time > mozilla-b2g:master

looks good to me.
Attachment #8611090 - Flags: review?(im) → review+
Comment on attachment 8611090 [details] [review]
[gaia] begeeben:1163506_display_time > mozilla-b2g:master

r+ valid only if the jshint failure get fixed. 

Overall it looks great. Please be sure to fix the jshint failure before landing.
Also please consider my comments on Github before landing.
Thanks!
Attachment #8611090 - Flags: review?(rexboy) → review+
Thanks! Fixed accordingly.
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/64291c716e7278e05834ff384d804d70ad691e8a
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S1 (26Jun)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: