Will, I would like to work on this project.
Assignee: nobody → kpsingh201091
Created attachment 8604769 [details] [review] Corrected titles in graph and comparison views Check my pull request !!
Attachment #8604769 - Flags: review?(wlachance)
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/bc6ba504c266054095adac0ac29d9a3699b226d0 Bug 1163580 - Titles in comparison and graphs view should reflect content
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/acaa8785ddee92c1e017efd69b34d7f19c5c8a3d Bug 1163580 - Fix edge case where updating document with no series
Comment on attachment 8604769 [details] [review] Corrected titles in graph and comparison views Thanks!! Some minor formatting issues, which I just fixed myself before merging. https://github.com/mozilla/treeherder-ui/commit/bc6ba504c266054095adac0ac29d9a3699b226d0
Attachment #8604769 - Flags: review?(wlachance) → review+
Realized after pushing that I missed an edge case where the series list had zero length in my review. Did a quick followup: https://github.com/mozilla/treeherder-ui/commit/acaa8785ddee92c1e017efd69b34d7f19c5c8a3d
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/edd9a0d103e71cb8b8c6361a9e5f104dcb32a32c Bug 1163580 - Titles in comparison and graphs view should reflect content https://github.com/mozilla/treeherder/commit/af2f31e63bd697276edb907768cd0e5eb8002b94 Bug 1163580 - Fix edge case where updating document with no series
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.