1163714 - Unhelpful "API Error 105" given when trying to push a commit with just an empty file to reviewboard

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P2)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: `h pr -r 265377::265378 --debug` output

Specifically:

abort: reviewboard error: "One or more fields had errors (HTTP 400, API Error 105)". please try submitting the review again. if that doesn't work, you've likely encountered a bug.

A google search reveals this is invalid form data [1]. However, I can't determine what is invalid and if it's something I'm doing or something the reviewboard extension/server is doing. I updated my version-control-tools repository to the latest version.

Commit data to follow.

[1]: https://www.reviewboard.org/docs/manual/1.5/webapi/2.0/errors/105-invalid-form-data/

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: `h log -fr "reverse(fx-team::)"` output

Note that I'm only trying to push the top two commits (i.e. I'm trying to avoid pushing nalexander's work in bug 1162191 and the two hacks I made on top of it).

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: `hg export -r 265378`

This patch is to work around the bug where I can't push a single draft() changeset to reviewboard.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: `hg export -r 265377`

The commit with the changes-to-be-reviewed in it.

Note that pushing this with the commits I didn't want to have reviewed works.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #3)
> Note that pushing this with the commits I didn't want to have reviewed works.

But adding the commit from comment 2 in causes an `hg push review` to fail in the same way.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Found the issue - I can't push a commit with just an empty file. I'm not sure if this applies if there is an empty file in addition to other changes within a commit, or if I delete the contents of a file to make it empty (i.e. I just added the file).

Comment 6

[Steven MacLeod [:smacleod]]

This specific case should be fixed by Bug 1161791.

Comment 7

[Gregory Szorc [:gps]]

There's still a bug here in that we're failing to catch an exception and turn it into something that is human friendly and actionable.

Thanks for tracking down the source of the error. Now we can repro and write a test case easily.

Comment 8

[Steven MacLeod [:smacleod]]

commits with just new empty files should now work, and be displayed, as part of MozReview.

Fixed by Bug 1161791