1163732 - [Contacts] Losing connection while importing contacts from Gmail or Outlook will show the user a screen with "Confirmation title" and an "Action 1" button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Joshua Mitchell (Inactive)]

Attachment: 2015-05-11-10-59-54.png

Description:
Trying to call a contact without the SIM enabled (by skipping SIM PIN entry screens) will result in a broken error message screen.


Repro Steps: (With SIM PIN enabled)
1) Update a Flame to 20150511010202
2) Skip SIM PIN when presented
3) Launch Contacts
4) Select contact with a phone number
5) Select the Call button (the phone)


Actual:
Broken error message screen encountered


Expected:
Error message explaining SIM is not active so no call can be made



Environmental Variables:
Device: Flame 3.0
Build ID: 20150511010202
Gaia: 6089234ace8b294a8feef064387604bae16254e3
Gecko: d8420a541d1c
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0



Repro frequency: 7/7
See attached: screenshot, logcat

Comment 1

[Joshua Mitchell (Inactive)]

This issue does NOT reproduce on Flame KK 2.2

Actual Results: A 'No network connection' message and 'ok' button are shown

Device: Flame 2.2 (KK - Nidghtly - Full Flash - 319mem)
Build ID: 20150511002500
Gaia: 528ef60e7cda09ad43478065f5d33bda398fbeb7
Gecko: 8d04cc085cf5
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150511_1141.txt

Comment 3

[Johan Lorenzo [:jlorenzo]]

Like in bug 1154415, this is likely caused by bug 1066347.

[Blocking Requested - why for this release]: Regression.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Log:

"
W/Communications( 1267): Content JS WARN: L10nError: "connectingEllipsis" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 1267):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:2115:9)
W/Communications( 1267): Content JS WARN: L10nError: "emergencyDialogBtnOk" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 1267):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:2115:9)
W/Communications( 1267): Content JS WARN: L10nError: "emergencyDialogTitle" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 1267):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:2115:9)
W/Communications( 1267): Content JS WARN: L10nError: "emergencyDialogBodyBadNumber" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 1267):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:2115:9)
W/Communications( 1267): Content JS WARN: L10nError: "emergencyDialogBtnOk" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 1267):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:2115:9)
"

Those entities are defined in
 - apps/communications//dialer/locales/dialer.en-US.properties
 - shared/locales//telephony/telephony.en-US.properties

and requested in contacts, but contact's index.html does not link to those resources.

Comment 5

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Nominated to block release as requested in comment 3. Requesting a window

Comment 6

[Brogan Zumwalt [Inactive]]

B2G-Inbound Regression Window:

Last working B2G-Inbound build:
Device: Flame 3.0
Build ID: 20150410033337
Gaia: 749b6eb12c103f4119f1f85c72dbe7791684d8dc
Gecko: b99b34dc9bd4
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First broken B2G-Inbound build:
Device:  Flame 3.0
BuildID: 20150410044437
Gaia: 6e403dbb863fb9ec41bd22b6583e2eff5045d78b
Gecko: 5a1b56e833f0
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Working Gaia with Broken Gecko issue does NOT reproduce:
Gaia: 749b6eb12c103f4119f1f85c72dbe7791684d8dc
Gecko: 5a1b56e833f0

Working Gecko with Broken Gaia issue DOES reproduce:
Gaia: 6e403dbb863fb9ec41bd22b6583e2eff5045d78b
Gecko: b99b34dc9bd4


B2G-Inbound Pushlog:
https://github.com/mozilla-b2g/gaia/compare/749b6eb12c103f4119f1f85c72dbe7791684d8dc...6e403dbb863fb9ec41bd22b6583e2eff5045d78b


Issue appears to occur due to changes made in bug 1066347

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

Zibi, can you take a look at this please? Here is another bug that might have been caused by the landing for bug 1066347.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

I commented in comment 4 :)

Comment 9

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression from bug 1066347

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression

Comment 12

[Shine(Leave from Mozilla)]

Attachment: Aries_kk_2.5.png

This problem can be reproduced on Aries KK 2.5 with this STR:
1. Launch Contacts app.
2. Enter Contacts Settings.
3. Import contacts from Gmail/Outlook account.
4. Sign in with a valid username and password.
5. Select some contacts to import.
6. During importing, disable network from Notification bar.
** The screen with "Confirmation title", "Action 1" and "Action 2" buttons will be shown.
See attachment: Aries_kk_2.5.png & logcat_Aries_KK_2.5_1731.txt
Rate: 5/5

Device information:
Aries KK 2.5 (Affected)
Build ID               20150803195455
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150803.191800
Firmware Date          Mon Aug  3 19:18:08 UTC 2015
Bootloader             s1

Comment 13

[Shine(Leave from Mozilla)]

Attachment: logcat_Aries_KK_2.5_1731.txt

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

I cannot reproduce with the STR from the description. And I cannot try with the STR from comment 12 because of bug 1200189.

Comment 15

[Fernando Jiménez Moreno [:ferjm]]

I managed to reproduce following the steps from comment 12

Comment 16

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1163732.contactsl10n > mozilla-b2g:master

Comment 17

[Borja Salguero [:borjasalguero]]

Comment on attachment 8654913 [details] [review]
[gaia] ferjm:bug1163732.contactsl10n > mozilla-b2g:master

Some comment in the code. Would it be possible to move out of 'facebook' the strings we need? Ideally this locales file should disappear in the near future. Thanks!

Comment 18

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8654913 [details] [review]
[gaia] ferjm:bug1163732.contactsl10n > mozilla-b2g:master

Thank you Borja. I just updated the PR.

I moved all the facebook related strings to import_contacts.

Comment 19

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/a613f3389a23133e05333cd0a7712979b3178717

Comment 20

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 12.

Actual results: Losing connection while importing contacts from Gmail/Outlook, it will show the screen with 'No internet connection' title and 'Cancel'&'OK' buttons as expected.
See attachment: verified_FlameKK_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150908150203
Gaia Revision          b81185d30e548f782770b852473ffb53c641a490
Gaia Date              2015-09-08 08:13:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b23b2fa33a9dcda59dbbca1d157eca3c32c5b862
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150908.183329
Firmware Date          Tue Sep  8 18:33:40 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150909010033
Gaia Revision          e69f2c86b931b723dd405115e33a1d02e6c5f5e6
Gaia Date              2015-09-08 20:39:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a4f512250d7d6199ae8c39eafdb3a2d8977a7dc4
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150909.002137
Firmware Date          Wed Sep  9 00:21:45 UTC 2015
Bootloader             s1

Comment 21

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.png