1163746 - Try removing JS_AlreadyHasOwnProperty

Status: NEW

(Core :: JavaScript Engine, enhancement, P5)

Description

[Tom S. (please needinfo tschuster)]

bug 1163423 comment 2
> So looking at consumers of JS_AlreadyHasOwnProperty(ById):
> 
> 1)  DOMProxyShadows is using it on the expando, so could use
> JS_HasOwnPropertyById.  Assuming that's not slower, of course.
> 
> 2)  In DefineConstructor, I'm not exactly sure why we need that check.  It
> might be possible to remove it, if we know that the global's resolve hook
> will always resolve the relevant properties before someone has a chance to
> redefine them.
> 
> 3)  Plugin code, no idea.  But those objects _do_ have resolve hooks, so
> need to check carefully.
> 
> 4)  XBL, pretty sure is working on objects with no resolve hooks only.
> 
> 5)  Xrays, working with holder objects, which have no resolve hook.

Comment 1

[Tom S. (please needinfo tschuster)]

I don't necessarily know more than bz here, so somebody else should take this.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I'm not going to have time for this in the near term.  The hard part here is the plugin bits, of course.