1163816 - "modelFor is not defined" in sdk/tabs/tab-fennec.js line: 258

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Off By None]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150511030203
Firefox for Android

Steps to reproduce:

Create an addon and require('sdk/tabs');
Build it for fennec and install addon.
Try to run the code


Actual results:

addon hits error and thus fails to start
console will show ReferenceError: modelFor is not defined <unknown>
Put a breakpoint on the line requiring sdk/tabs and you will be able to get the exception with the details:
fileName: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-fennec.js
lineNumber: 258
message: modelFor is not defined
stack: "@resource://gre/modules/commonjs/sdk/tabs/tab-fennec.js:258:1CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:79:18@resource://gre/modules/commonjs/sdk/tabs/tab.js:15:20CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:79:18@resource://gre/modules/commonjs/sdk/windows/tabs-fennec.js:7:17CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:79:18@resource://gre/modules/commonjs/sdk/tabs.js:11:20CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:79:18CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:79:18main@resource://jid1-a3bemgzqqjovng-at-jetpack/lib/main.js:10:29run@resource://gre/modules/commonjs/sdk/addon/runner.js:151:1startup/</<@resource://gre/modules/commonjs/sdk/addon/runner.js:86:7Handler.prototype.process@resource://gre/modules/Promise-backend.js:867:23this.PromiseWalker.walkerLoop@resource://gre/modules/Promise-backend.js:746:7this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise-backend.js:688:37Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise-backend.js:688:5this.PromiseWalker.schedulePromise@resource://gre/modules/Promise-backend.js:709:7this.PromiseWalker.completePromise@resource://gre/modules/Promise-backend.js:671:7readURI/<@resource://gre/modules/commonjs/sdk/net/url.js:55:9NetUtil_asyncFetch2/<.onStopRequest@resource://gre/modules/NetUtil.jsm:212:17"



Expected results:

should not have thrown the error.


This starting happening with yesterdays build (5-10-2015) on Nightly Firefox for android - It is on my phone that I see the error.  My tablet still has the version from Saturday (5-9-2015) and it does not produce this problem.

Comment 1

[Loic]

Could you attach a minimal self-contained add-on/testcase to reproduce the error, please. It'd help to find a possible regression range.

Comment 2

[Off By None]

Attachment: Source and XPI of repro

The addon should open a tab to this page when installed.  It will run on desktop or mobile.  It works on my nexus 7 with the build from 5-9-2015 but not on my htc one m7 on any build since 5-9

Comment 3

[Alexander]

Aurora 39 (and Nightly 40 for most of the time) branches were free from this bug. I found it in very first Aurora 40 build. Who added these faulty last lines to tab-fennec.js and WHAT FOR?

Comment 4

[Alexander]

I guess
var{modelFor}=require("../model/core");
was missed in the beginning of tab-fennec.js (or may be const{...?).

Comment 6

[:Gijs (out for now; he/him)]

[Tracking Requested - why for this release]:
Serious add-on compat issue on fennec


Pulling in some Fennec folks as well. Erik, can you investigate this in the near future? This looks pretty broken.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This seems to be a regression. Adding a tracking flag for firefox40 and firefox41 as it's also marked as affected.

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

Mossop worked on the file last, I'll let him take a look.  I'm not sure who else is working on the SDK at the moment.

Comment 9

[Dave Townsend [:mossop]]

(In reply to Alexander from comment #4)
> I guess
> var{modelFor}=require("../model/core");
> was missed in the beginning of tab-fennec.js (or may be const{...?).

This is exactly right, it's fallout from bug 854982.

Clearing testcase-wanted since we have automated tests for this, we just don't run them on Fennec: bug 809143

Comment 10

[Dave Townsend [:mossop]]

Attachment: pull request

One other problem here, getTabForBrowser from helpers.js used to return null and now returns undefined. Not sure what else relied on that so I switched it back to null.

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0c1b766ded5cefb9a345f4ba5ddbc32b127f114e
Bug 1163816: Fix Fennec bustage from bug 854982.

https://github.com/mozilla/addon-sdk/commit/8e6cc79651aae915471913e45a2d38a4d651ac6f
Merge pull request #1974 from Mossop/bug1163816

Bug 1163816: Fix Fennec bustage from bug 854982. r=jsantell

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d455e4d9198d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d455e4d9198d

Comment 14

[Dave Townsend [:mossop]]

Comment on attachment 8608949 [details] [review]
pull request

Approval Request Comment
[Feature/regressing bug #]: bug 854982
[User impact if declined]: Some SDK based add-ons won't work on Fennec
[Describe test coverage new/current, TreeHerder]: Only manual testing :(
[Risks and why]: Low risk, this can only improve the situation which is totally broken at this point
[String/UUID change made/needed]: None

Comment 15

[Alexander]

Please, excuse me if I didn't get it right, but flags show only firefox41 is fixed. Firefox40 is still "affected". Does it mean it will go beta, then release with this bug not fixed?

Comment 16

[:Gijs (out for now; he/him)]

(In reply to Alexander from comment #15)
> Please, excuse me if I didn't get it right, but flags show only firefox41 is
> fixed. Firefox40 is still "affected". Does it mean it will go beta, then
> release with this bug not fixed?

No, that's what comment #14 is about.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8608949 [details] [review]
pull request

Should be safe, taking it.

Comment 18

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19e307d1bf54