If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add integration with browsermob-proxy

RESOLVED FIXED in Firefox 41

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Syd needs to use the browsermob-proxy (https://github.com/lightbody/browsermob-proxy) to vary bandwidth in media Marionette tests.

This has some Selenium integration via https://github.com/AutomatedTester/browsermob-proxy-py; we need to decide how to integrate it with Marionette.

One approach would be to create a mixin which can start/stop the proxy if a command-line arg is present, and would add a method that tests can use to set the Firefox proxy by means of setting the relevant pref.
(Assignee)

Comment 1

3 years ago
David, what would you recommend?
Flags: needinfo?(dburns)
We need to have a mechanism for setting up a proxy and ideally we want to be doing that on newSession so that we can keep the webdriver semantics.

I have a draft of how capabilities will work up at https://github.com/w3c/webdriver/pull/32/files#diff-ad773c123fb4f302446d8ca4ab22109cR127 and will be doing proxy next so I can remove the todo that is visible int he diff.

This is one of my main priorities currently.
Flags: needinfo?(dburns)
Depends on: 1165449
(Assignee)

Comment 3

2 years ago
I'm going to take this piece.  David, bug 1165449 isn't a huge rush; I can work around this for the time being by setting the proxy pref via execute_script.
Assignee: nobody → jgriffin
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
Created attachment 8610709 [details]
MozReview Request: bz://1163833/jgriffin

/r/9369 - Bug 1163833 - Add integration with browsermob-proxy, r=dburns

Pull down this commit:

hg pull -r 4b31ed43f1920af94d7eb2154e267e23e28c2a5d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8610709 - Flags: review?(dburns)
(Assignee)

Comment 5

2 years ago
I didn't include browsermob-proxy itself; the package contains too many binary JAR files.

try run to verify I didn't mess up packaging details:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=133698b38a07
Comment on attachment 8610709 [details]
MozReview Request: bz://1163833/jgriffin

https://reviewboard.mozilla.org/r/9367/#review8175

Ship It!
Attachment #8610709 - Flags: review?(dburns) → review+
(Assignee)

Updated

2 years ago
Blocks: 1168997

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f11faab4b144
https://hg.mozilla.org/mozilla-central/rev/f11faab4b144
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: 1169714
(Assignee)

Comment 9

2 years ago
Comment on attachment 8610709 [details]
MozReview Request: bz://1163833/jgriffin
Attachment #8610709 - Attachment is obsolete: true
Attachment #8620269 - Flags: review+
(Assignee)

Comment 10

2 years ago
Created attachment 8620269 [details]
MozReview Request: Bug 1163833 - Add integration with browsermob-proxy, r=dburns
You need to log in before you can comment on or make changes to this bug.