1163908 - [LayerScope] Add Heat map in viewer

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[u459114]

Provide heat map image at viewer side. So that we know
1. how texture been composed
2. the level of overdraw

Comment 1

[u459114]

Attachment: Export heat map

Comment 2

[u459114]

Attachment: Export heat map

Comment 3

[u459114]

Attachment: LayerScope viewer

Comment 4

[u459114]

Comment on attachment 8607566 [details] [diff] [review]
Export heat map

jerry/boris, Have time to look through this change?

Comment 5

[u459114]

Comment on attachment 8607570 [details] [review]
LayerScope viewer

>https://github.com/mozilla/layerscope/pull/21

Comment 6

[u459114]

Comment on attachment 8607570 [details] [review]
LayerScope viewer

https://github.com/mozilla/layerscope/pull/21

Comment 7

[u459114]

Attachment: LayerScope heat-map view on the viewer

Comment 8

[u459114]

By using heat-map view in layerscope, we are able to know how compositor draw squares, and tell the severity of overdraw in the current scene.

Comment 9

[u459114]

Attachment: [Image] Heat-map view

Comment 10

[u459114]

Attachment: export draw commands

Comment 11

[u459114]

Attachment: [Image] Heat-map view

Comment 12

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8608174 [details] [diff] [review]
export draw commands

Review of attachment 8608174 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/LayerScope.cpp
@@ +450,5 @@
> +        DrawPacket* dp = packet.mutable_draw();
> +        dp->set_layerref(mLayerRef);
> +        dp->set_offsetx(mOffsetX);
> +        dp->set_offsety(mOffsetY);
> +        dp->set_mvmatrix((void *)&mMVMatrix, sizeof(Float) * 16);

sizeof(Matrix4x4)?

@@ +452,5 @@
> +        dp->set_offsetx(mOffsetX);
> +        dp->set_offsety(mOffsetY);
> +        dp->set_mvmatrix((void *)&mMVMatrix, sizeof(Float) * 16);
> +        dp->set_totalrects(mRects);
> +        for (size_t i = 0; i < mRects; i++) { 

If we only have 4 maximum of rects, add an assert here.

Comment 13

[u459114]

Attachment: [B2G::Image] Heat-map view

Comment 14

[u459114]

Attachment: LayerScope heat map

Comment 15

[u459114]

Comment on attachment 8608604 [details] [diff] [review]
LayerScope heat map

Review of attachment 8608604 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Dan,
This patch is to export data layerscope::viewer need of display heat-map view.
1. Export uniform/ attribute of each draw call to layerscope.
2. Layerscope then package and forward draw information to the viewer.

Comment 16

[u459114]

Attachment: LayerScope heat-map view on the viewer

Hi Jerry/Boris,
Here is heap-map implementation on the viewer side.
1. Fetch draw data from the device and convert it to frame.draws object in dataprocessor worker.
2. Replay draw commands on the viewer side by webgl.

Comment 17

[u459114]

Comment on attachment 8608628 [details] [review]
LayerScope heat-map view on the viewer

>https://github.com/mozilla/layerscope/pull/23

Comment 18

[u459114]

Attachment: Live demo

Comment 19

[u459114]

Try result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=771245b9aab5

Comment 20

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8608628 [details] [review]
LayerScope heat-map view on the viewer

Since we use the viewer at desktop, some performance issue might not noticeable.
I don't check the TwoDViewImp() very clearly. I don't really understand css selector and your dom structure.
Please check the comment at github.

Comment 21

[u459114]

(In reply to Jerry Shih[:jerry] (UTC+8) from comment #20)
> Comment on attachment 8608628 [details] [review]
> LayerScope heat-map view on the viewer
> 
> Since we use the viewer at desktop, some performance issue might not
> noticeable.
> I don't check the TwoDViewImp() very clearly. I don't really understand css
> selector and your dom structure.
> Please check the comment at github.
OK, thank.

Comment 22

[u459114]

Attachment: LayerScope heat map

Testing result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f05ff5576370

Comment 23

[u459114]

Attachment: LayerScope heat-map view on the viewer

Comment 24

[Boris Chiou [:boris]]

We will merge viewer side after gecko side is checked in.

Comment 25

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4dcd8361800

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4dcd8361800

Comment 27

[u459114]

(In reply to Boris Chiou [:boris] from comment #24)
> We will merge viewer side after gecko side is checked in.
Pull request
https://github.com/mozilla/layerscope/pull/24/files

Comment 28

[Boris Chiou [:boris]]

(In reply to C.J. Ku[:cjku] from comment #27)
> (In reply to Boris Chiou [:boris] from comment #24)
> > We will merge viewer side after gecko side is checked in.
> Pull request
> https://github.com/mozilla/layerscope/pull/24/files

Merged. You can resolve this bug after checking-in into mozilla-central.

Comment 29

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f4dcd8361800