Open Bug 1163931 Opened 4 years ago Updated 4 years ago

"View Pocket List" prevents going back to previous page due to server redirects

Categories

(Firefox :: Pocket, defect, P3)

41 Branch
defect

Tracking

()

Tracking Status
firefox38.0.5 --- affected
firefox39 --- affected
firefox40 --- affected

People

(Reporter: Fanolian+BMO, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150511122605

Steps to reproduce:

0. Logged into Pocket
1. On a tab, load any page other than about:newtab, e.g. about:home.
2. Click "View Pocket List" in bookmark menu.
3. Click back button after https://getpocket.com/a/queue is loaded.


Actual results:

I cannot go back to previous page, i.e. about:home.
https://getpocket.com/a/ is loaded and immediately redirected to https://getpocket.com/a/queue, resulting a loop.

The bug may be a Pocket's site issue, but I think this cannot be ignored since Firefox decides to integrate Pocket and turn it on by default.

Even if I manually load https://getpocket.com/a/queue, 2 back actions is required to go back to previous page (but not resulting a loop).
Blocks: Pocket
Component: Untriaged → Pocket
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: qe-verify+
OS: Unspecified → All
Hardware: Unspecified → All
Summary: "View Pocket List" prevents going back to previous page due to a loop → "View Pocket List" prevents going back to previous page due to server redirects
Possibly something that could be fixed on Pocket's side, possible we could fix it in browser by linking straight to the final page.

But this also feels like an existing issue, in that clicking the back button with redirects like these ought to do something smarter.
Priority: -- → P3
:dolske, what direction do we want to go in for a fix for V2?
Blocks: 1168408
Flags: needinfo?(dolske)
Hmm, this is curious. The network devtools shows the following:

1) Browser requests https://getpocket.com/?src=ff_ext

2) Server replies with a HTTP 302 redirect to http://getpocket.com/a/

3) Browser requests http://getpocket.com/a/

4) Server replies with a HTTP 301 redirect to https://getpocket.com/a/

The 302 in step 2 may not be the entire cause of this bug, but seems problematic to be redirecting a secure connection to an insecure connection. So Pocket should definitely fix that on their end.

We can change the in-product URL for 39, since that's trivial. Would still be nice to have a bug on file to handle redirects better (maybe that's bug 805866) and ideally fix that too.
Flags: needinfo?(dolske)
Flags: needinfo?(nate)
Pocket just fixed the insecure redirect, but this main issue this bug about is still exists.

I also noticed that, at least now, the previous history entry is actually where the redirect sent us, so that's not actually the issue.

1) Load "https://getpocket.com"
2) 302 to https://getpocket.com/a/"
3) something puts us on https://getpocket.com/a/queue/

The previous history entry is step 2.

If I disable browser.history.allowPushState, things work properly:

1) Load dolske.net
2) Load https://getpocket.com/?src=ff_ext
3) (note loaded page is .../a/queue/)
4) Click back button
5) now on dolske.net

So,  the browser isn't being as helpful as it maybe could be with pushState, but might also be fixable on Pocket's end? (I've had problems with Firefox + pushState on other sites, so still would nice if we looked at a general fix.)
Flags: needinfo?(nate)
You need to log in before you can comment on or make changes to this bug.