1163946 - [RTL][Settings]The value of "Debugging via USB" in value selector and value list are different.

Status: RESOLVED WONTFIX

(Mozilla Localizations :: ar / Arabic, defect, P3)

Description

[Sue]

Attachment: Debugging via USB.png

[1.Description]:
[RTL][Flame v2.2 & v3.0][Nexus 5 2.2 & 3.0][Settings]The value in value selector and value list are different. The values in value selector are "ADB only" and "ADB and DevTools", but that in value list is "only ADB" and "and DevTools ADB".
See attachment:Debugging via USB.png

[2.Testing Steps]: 
1.Set system language as Arabic.
2. Launch Settings -> Developer.
3. Observe the value of "Debugging via USB" in value selector.
4. Tap the value selector under "Debugging via USB" and observe the value list.

[3.Expected Result]: 
3&4. The value in both value selector and value list should be the same.

[4.Actual Result]: 
3&4. The value in value selector and value list are different.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150511002500
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150511.035847
Firmware Date          Mon May 11 03:58:59 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150511160205
Gaia Revision          6089234ace8b294a8feef064387604bae16254e3
Gaia Date              2015-05-10 13:57:12
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/502e1a5e722f
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150511.193556
Firmware Date          Mon May 11 19:36:04 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150511002500
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150511.034716
Firmware Date          Mon May 11 03:47:32 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (affected)
Build ID               20150511160205
Gaia Revision          6089234ace8b294a8feef064387604bae16254e3
Gaia Date              2015-05-10 13:57:12
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/502e1a5e722f
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150511.193757
Firmware Date          Mon May 11 19:38:13 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel]

Triage: P3. Will break string freeze on 2.2, but would be good to get a fix for 3.0

Comment 2

[Alissa（leave from Mozilla）]

This issue can be reproduced on latest build of AriesKK_v2.5.
Rate:5/5
Device:AriesKK_V2.5
Build ID               20150811234258
Gaia Revision          c7875bbc8b32e7b95cc55c9690b03b140905d84d
Gaia Date              2015-08-11 18:18:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d4f3a8a75577e4af2914a4e899ca2e724f9715c4
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150811.230622
Firmware Date          Tue Aug 11 23:06:29 UTC 2015
Bootloader             s1

Comment 3

[Lancy(Leave from Mozilla)]

This issue still can be reproduced on latest AriesKK&FlameKK v2.5 build.
FlameKK v2.5 (512mb)Build ID:20151101150206
AriesKK v2.5 Build ID:20151101012023

Comment 4

[Augustin Trancart [:autra]]

This is a localization issue. Probably RLM needs to be added in front of the string.

Comment 5

[Sam Foster [:sfoster] (he/him)]

:nefzaoui, can you move this to the right component and ensure we don't lose track of this for all our other RTL locales - I'm not sure what the process is for that.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Augustin Trancart [:autra] from comment #4)
> This is a localization issue. Probably RLM needs to be added in front of the
> string.

It's a choice selector in system app. Can we fix it in the whole selector instead of fixing it for this one string?

Comment 7

[William Hsu [:whsu]]

Let's temporarily move the bug to “Product: Mozilla Localizations” and double check if bug happens on the other RTL languages.

Comment 8

[Augustin Trancart [:autra]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #6)
> (In reply to Augustin Trancart [:autra] from comment #4)
> > This is a localization issue. Probably RLM needs to be added in front of the
> > string.
> 
> It's a choice selector in system app. Can we fix it in the whole selector
> instead of fixing it for this one string?

Maybe, but I don't see how. The thing is that:
- the label of the select is handled by l10n (AFAIK), so does not have dir="auto": string display ok, because element inherits a RTL dir from its context.
- The value selector in the system app does have a dir="auto" on each of its element. This is necessary because values can come from multiple sources, from the user or for loca files etc. Then the direction is calculated according to the content of the string (and as the string starts with LTR char, the order of words will be LTR). We can't change that without breaking other cases, I'm afraid.

IMHO, it's the job of the localized string (or the loca lib) to make sure it displays ok in a dir="auto" context, thus the use of RLM to say "hey I'm a RTL string you know?". Maybe that could be done in l10n.js if you really wants it fixed for every string. We could automagically add a RLM in front of strings that starts with a LTR char in an RTL language. TBH I'm not a huge fan of this magical solution, but if we think carefully about the implication, it might be safe to do so. 

WDYT Zibi?

Comment 9

[Augustin Trancart [:autra]]

And btw, if we do so, it would also avoid bugs like bug 1218733.

Comment 10

[Khaled Hosny]

We no longer localize FFOS.