1163963 - Toolbar text fade overlaps url bar with non-default Android text sizes

Status: RESOLVED DUPLICATE of bug 1320605

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Catalin Suciu [:csuciu]]

Please check the screenshots: http://imgur.com/xI0Y9C4

I'm seeing this only on Samsung Galaxy S5 (4.4.2)

Firefox 35 is also affected so this is not a recent regression.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I have a Galaxy S5 and I haven't seen this issue - are there any Android settings you've changed (e.g. font size)?

Precedent: bug 1117130.
Caused by: bug 1105472.

Comment 2

[Richard Newman [:rnewman]]

tracking? in the expectation that Catalin will have answered by Thursday!

Comment 3

[Catalin Suciu [:csuciu]]

(In reply to Michael Comella (:mcomella) from comment #1)
> I have a Galaxy S5 and I haven't seen this issue - are there any Android
> settings you've changed (e.g. font size)?

Yup, changing Android font size from Small (default) to anything larger reveals this issue.  
Also, this is not device specific. I was able to reproduce on multiple devices with Android 4.1.x, 4.4.x

Comment 4

[Kevin Brosnan [:kbrosnan]]

Attachment: Screenshot (left is the enlarged Android text size)

Comment 5

[Kevin Brosnan [:kbrosnan]]

Minus, could reconsider if we get more reports.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

I believe this may occur with some devices in the factory default configuration, such as the Huawei Y625.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

The place to look in this code is the FadedMultiColorTextView. It works by drawing a gradient rectangle with the background color (white in non-private browsing) over the text, fading it out – this gradient is being drawn too large and should be calculated by the text size (or the Text's bounding box) rather than the current implementation which, iirc, does some approximations.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Any movement here Mailkov?

Comment 11

[Melchiorre Alastra (:Mailkov)]

Michael, I`ll solve this next week

Comment 12

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Reset assignee due to inactivity.

Comment 13

[bradb]

Seeing this on my S7 Edge as well. Worked around by reducing system font size.

Comment 14

[lgbrowser5]

It’s not fixed in 51
I hope you can check this issue.
Thanks and BR.

Comment 15

[Nevin Chen(Not active on Bugzilla)]

Hi!
It should be solved by bug 1300564 and bug 1320605
Could you please help check on Nightly?
Or may I know your app version so I get investigate further?
Thank you!

Comment 16

[lgbrowser5]

Currently, preload Firefox is 51 version.
I checked the Beta(V52.0b6)version.
Thanks very much for your help.

Comment 17

[Catalin Suciu [:csuciu]]

Confirming that this issue is fixed in latest Beta, Aurora and Nightly.

Fixed in bug #1320605.

Comment 18

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

51 is in release so we probably won't get approved to uplift.

Comment 19

[Mike Kaply [:mkaply]]

Resolving duplicate.

Clearing kbrosnan request. I'll request uplift in 132065 (longshot).