Closed Bug 1163963 Opened 6 years ago Closed 4 years ago

Toolbar text fade overlaps url bar with non-default Android text sizes

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox38 affected, firefox39 affected, firefox40 affected, firefox41 affected, fennec-)

RESOLVED DUPLICATE of bug 1320605
Tracking Status
firefox38 --- affected
firefox39 --- affected
firefox40 --- affected
firefox41 --- affected
fennec - ---

People

(Reporter: csuciu, Unassigned, Mentored, NeedInfo)

References

Details

Attachments

(1 file)

Please check the screenshots: http://imgur.com/xI0Y9C4

I'm seeing this only on Samsung Galaxy S5 (4.4.2)

Firefox 35 is also affected so this is not a recent regression.
I have a Galaxy S5 and I haven't seen this issue - are there any Android settings you've changed (e.g. font size)?

Precedent: bug 1117130.
Caused by: bug 1105472.
Blocks: 1105472
See Also: → 1117130
Flags: needinfo?(catalin.suciu)
tracking? in the expectation that Catalin will have answered by Thursday!
tracking-fennec: --- → ?
Component: General → Theme and Visual Design
(In reply to Michael Comella (:mcomella) from comment #1)
> I have a Galaxy S5 and I haven't seen this issue - are there any Android
> settings you've changed (e.g. font size)?

Yup, changing Android font size from Small (default) to anything larger reveals this issue.  
Also, this is not device specific. I was able to reproduce on multiple devices with Android 4.1.x, 4.4.x
Flags: needinfo?(catalin.suciu)
Summary: Bad display of URL bar on Galaxy S5 → Bad display of URL bar
Summary: Bad display of URL bar → Toolbar text fade overlaps url bar with non-default Android text sizes
Minus, could reconsider if we get more reports.
tracking-fennec: ? → -
Mentor: michael.l.comella
I believe this may occur with some devices in the factory default configuration, such as the Huawei Y625.
The place to look in this code is the FadedMultiColorTextView. It works by drawing a gradient rectangle with the background color (white in non-private browsing) over the text, fading it out – this gradient is being drawn too large and should be calculated by the text size (or the Text's bounding box) rather than the current implementation which, iirc, does some approximations.
Assignee: nobody → miticomilko
Any movement here Mailkov?
Flags: needinfo?(miticomilko)
Michael, I`ll solve this next week
Flags: needinfo?(miticomilko)
Reset assignee due to inactivity.
Assignee: miticomilko → nobody
Seeing this on my S7 Edge as well. Worked around by reducing system font size.
It’s not fixed in 51
I hope you can check this issue.
Thanks and BR.
Flags: needinfo?(kbrosnan)
Hi!
It should be solved by bug 1300564 and bug 1320605
Could you please help check on Nightly?
Or may I know your app version so I get investigate further?
Thank you!
Flags: needinfo?(lgbrowser5)
Flags: needinfo?(catalin.suciu)
Flags: needinfo?(bradb)
Currently, preload Firefox is 51 version.
I checked the Beta(V52.0b6)version.
Thanks very much for your help.
Flags: needinfo?(lgbrowser5)
Confirming that this issue is fixed in latest Beta, Aurora and Nightly.

Fixed in bug #1320605.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(catalin.suciu)
Resolution: --- → FIXED
51 is in release so we probably won't get approved to uplift.
Resolving duplicate.

Clearing kbrosnan request. I'll request uplift in 132065 (longshot).
Flags: needinfo?(kbrosnan)
Resolution: FIXED → DUPLICATE
Duplicate of bug: 1320605
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.