Closed Bug 1163977 Opened 9 years ago Closed 9 years ago

[Stingray] smart-bubbles sinking animation has a glitch at the last frame

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

Attachments

(2 files)

possible.patch
1.33 KB, patch
Details | Diff | Splinter Review
pull request
56 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review 
Smart-bubbles sinking animation has a glitch at the last frame. Bubbles are displayed at original position in the end for a very short time.
Attached patch possible.patch — — Splinter Review 
John has provided a possible patch for it.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Attached file pull request — 
Hi John,
Please help to review the patch. Thanks
Attachment #8605016 - Flags: review?(im)
Comment on attachment 8605016 [details] [review]
pull request

Looks good to me. Hope this version runs well.

Please add more comment to say why we do it before landing it.
Attachment #8605016 - Flags: review?(im) → review+
Thanks.

Landed in smart-bubbles/master
https://github.com/smart-components/smart-bubbles/commit/5c08ef5d84b0bd1d8252600cfc744aa7869e9f92
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: