Closed
Bug 1164007
Opened 9 years ago
Closed 9 years ago
test_TelemetryTimestamps.js is going to permafail on Windows when Gecko 39 merges to Beta
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
VERIFIED
FIXED
mozilla41
People
(Reporter: RyanVM, Assigned: Dexter)
References
Details
(Whiteboard: [uplift])
Attachments
(2 files, 3 obsolete files)
1.71 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
3.41 KB,
patch
|
gfritzsche
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Failing on all Windows platforms since yesterday's uplift. https://treeherder.mozilla.org/logviewer.html#?job_id=364240&repo=mozilla-beta 18:25:36 INFO - TEST-START | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js 18:25:37 WARNING - TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | xpcshell return code: 0 18:25:37 INFO - TEST-INFO took 420ms 18:25:37 INFO - >>>>>>> 18:25:37 INFO - (xpcshell/head.js) | test MAIN run_test pending (1) 18:25:37 INFO - PROCESS | 2588 | 1431397536788 addons.manager DEBUG Application has been upgraded 18:25:37 INFO - PROCESS | 2588 | 1431397536795 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider"] 18:25:37 INFO - PROCESS | 2588 | 1431397536796 addons.manager DEBUG Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"] 18:25:37 INFO - PROCESS | 2588 | 1431397536798 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm 18:25:37 INFO - PROCESS | 2588 | 1431397536799 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm 18:25:37 INFO - "Mock profileBeforeChange blocker for 'AddonManager: shutting down.'" 18:25:37 INFO - PROCESS | 2588 | 1431397536799 addons.manager DEBUG Starting provider: XPIProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536800 addons.xpi DEBUG startup 18:25:37 INFO - PROCESS | 2588 | 1431397536800 addons.xpi DEBUG checkForChanges 18:25:37 INFO - PROCESS | 2588 | 1431397536800 addons.xpi DEBUG Loaded add-on state from prefs: {} 18:25:37 INFO - PROCESS | 2588 | 1431397536801 addons.xpi DEBUG getInstallState changed: false, state: {} 18:25:37 INFO - PROCESS | 2588 | 1431397536801 addons.xpi DEBUG Empty XPI database, setting schema version preference to 16 18:25:37 INFO - PROCESS | 2588 | 1431397536802 addons.xpi DEBUG No changes found 18:25:37 INFO - PROCESS | 2588 | 1431397536802 addons.manager DEBUG Registering shutdown blocker for XPIProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536803 addons.manager DEBUG Provider finished startup: XPIProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536803 addons.manager DEBUG Starting provider: LightweightThemeManager 18:25:37 INFO - PROCESS | 2588 | 1431397536803 addons.manager DEBUG Registering shutdown blocker for LightweightThemeManager 18:25:37 INFO - PROCESS | 2588 | 1431397536803 addons.manager DEBUG Provider finished startup: LightweightThemeManager 18:25:37 INFO - PROCESS | 2588 | 1431397536804 addons.manager DEBUG Starting provider: GMPProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536806 addons.manager DEBUG Registering shutdown blocker for GMPProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536806 addons.manager DEBUG Provider finished startup: GMPProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536806 addons.manager DEBUG Starting provider: PluginProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536807 addons.manager DEBUG Registering shutdown blocker for PluginProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536807 addons.manager DEBUG Provider finished startup: PluginProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536809 addons.manager DEBUG Completed startup sequence 18:25:37 INFO - (xpcshell/head.js) | test pending (2) 18:25:37 INFO - (xpcshell/head.js) | test MAIN run_test finished (2) 18:25:37 INFO - running event loop 18:25:37 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function" {file: "C:/slave/test/build/tests/xpcshell/tests/toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js -> file:///C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js" line: 1365 column: 11 source: " function MockWindowsRegKey() { 18:25:37 INFO - "}]" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536788 addons.manager DEBUG Application has been upgraded" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536795 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider"]" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536796 addons.manager DEBUG Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]" 18:25:37 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property this.KEY_LOG_BASE" {file: "resource://gre/modules/GMPUtils.jsm" line: 92}]" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536798 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536799 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536799 addons.manager DEBUG Starting provider: XPIProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536800 addons.xpi DEBUG startup" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536800 addons.xpi DEBUG checkForChanges" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536800 addons.xpi DEBUG Loaded add-on state from prefs: {}" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536801 addons.xpi DEBUG getInstallState changed: false, state: {}" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536801 addons.xpi DEBUG Empty XPI database, setting schema version preference to 16" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536802 addons.xpi DEBUG No changes found" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536802 addons.manager DEBUG Registering shutdown blocker for XPIProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536803 addons.manager DEBUG Provider finished startup: XPIProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536803 addons.manager DEBUG Starting provider: LightweightThemeManager" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536803 addons.manager DEBUG Registering shutdown blocker for LightweightThemeManager" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536803 addons.manager DEBUG Provider finished startup: LightweightThemeManager" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536804 addons.manager DEBUG Starting provider: GMPProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "formatURLPref: Couldn't get pref: app.support.baseURL" {file: "resource://gre/components/nsURLFormatter.js" line: 136}]" 18:25:37 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "formatURLPref: Couldn't get pref: app.support.baseURL" {file: "resource://gre/components/nsURLFormatter.js" line: 136}]" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536806 addons.manager DEBUG Registering shutdown blocker for GMPProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536806 addons.manager DEBUG Provider finished startup: GMPProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536806 addons.manager DEBUG Starting provider: PluginProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536807 addons.manager DEBUG Registering shutdown blocker for PluginProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536807 addons.manager DEBUG Provider finished startup: PluginProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536809 addons.manager DEBUG Completed startup sequence" 18:25:37 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2) 18:25:37 INFO - toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | Starting actualTest 18:25:37 INFO - (xpcshell/head.js) | test actualTest pending (3) 18:25:37 INFO - (xpcshell/head.js) | test run_next_test 0 finished (3) 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 70] true == true 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 71] true == true 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 78] 64060588800000 == 64060588800000 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 82] 64060588800000 == 64060588800000 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 90] true == true 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 91] "undefined" == null 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 95] true == true 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 96] true == true 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 97] true == true 18:25:37 INFO - TEST-PASS | toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js | actualTest - [actualTest : 98] "undefined" == "undefined" 18:25:37 INFO - PROCESS | 2588 | 1431397536848 addons.xpi-utils DEBUG Starting async load of XPI database c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmp6ic_p_\\extensions.json 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536848 addons.xpi-utils DEBUG Starting async load of XPI database c:\\docume~1\\cltbld~1.t-x\\locals~1\\temp\\tmp6ic_p_\\extensions.json" 18:25:37 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "TelemetryScheduler.shutdown - Already shut down" {file: "resource://gre/modules/TelemetrySession.jsm" line: 706}]" 18:25:37 INFO - PROCESS | 2588 | 1431397536854 addons.xpi-utils DEBUG Rebuilding XPI database with no extensions 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536854 addons.xpi-utils DEBUG Rebuilding XPI database with no extensions" 18:25:37 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property this._environment._currentEnvironment.addons" {file: "resource://gre/modules/TelemetryEnvironment.jsm" line: 461}]" 18:25:37 INFO - Unexpected exception Error: at (unknown module) 18:25:37 INFO - this.BasePromiseWorker.prototype.post@resource://gre/modules/PromiseWorker.jsm:263:1 18:25:37 INFO - post/<@resource://gre/modules/osfile/osfile_async_front.jsm:429:25 18:25:37 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23 18:25:37 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7 18:25:37 INFO - this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37 18:25:37 INFO - Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:5 18:25:37 INFO - this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:709:7 18:25:37 INFO - this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:671:7 18:25:37 INFO - this.BasePromiseWorker.prototype._worker/worker.onmessage@resource://gre/modules/PromiseWorker.jsm:231:9 18:25:37 INFO - _do_main@C:\slave\test\build\tests\xpcshell\head.js:207:5 18:25:37 INFO - _execute_test@C:\slave\test\build\tests\xpcshell\head.js:506:5 18:25:37 INFO - @-e:1:1 18:25:37 INFO - _run_next_test@C:\slave\test\build\tests\xpcshell\head.js:1377:9 18:25:37 INFO - do_execute_soon/<.run@C:\slave\test\build\tests\xpcshell\head.js:646:9 18:25:37 INFO - _do_main@C:\slave\test\build\tests\xpcshell\head.js:207:5 18:25:37 INFO - _execute_test@C:\slave\test\build\tests\xpcshell\head.js:506:5 18:25:37 INFO - @-e:1:1 18:25:37 INFO - exiting test 18:25:37 INFO - PROCESS | 2588 | 1431397536920 addons.manager DEBUG shutdown 18:25:37 INFO - PROCESS | 2588 | 1431397536920 addons.manager DEBUG Calling shutdown blocker for XPIProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536921 addons.xpi DEBUG shutdown 18:25:37 INFO - PROCESS | 2588 | 1431397536921 addons.xpi-utils DEBUG shutdown 18:25:37 INFO - PROCESS | 2588 | 1431397536921 addons.manager DEBUG Calling shutdown blocker for LightweightThemeManager 18:25:37 INFO - PROCESS | 2588 | 1431397536921 addons.manager DEBUG Calling shutdown blocker for GMPProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536922 addons.manager DEBUG Calling shutdown blocker for PluginProvider 18:25:37 INFO - PROCESS | 2588 | 1431397536923 addons.xpi DEBUG Notifying XPI shutdown observers 18:25:37 INFO - PROCESS | 2588 | 1431397536924 addons.manager DEBUG Async provider shutdown done 18:25:37 INFO - "gXPISaveError set to: null" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536920 addons.manager DEBUG shutdown" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536920 addons.manager DEBUG Calling shutdown blocker for XPIProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536921 addons.xpi DEBUG shutdown" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536921 addons.xpi-utils DEBUG shutdown" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536921 addons.manager DEBUG Calling shutdown blocker for LightweightThemeManager" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536921 addons.manager DEBUG Calling shutdown blocker for GMPProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536922 addons.manager DEBUG Calling shutdown blocker for PluginProvider" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536923 addons.xpi DEBUG Notifying XPI shutdown observers" 18:25:37 INFO - "CONSOLE_MESSAGE: (info) 1431397536924 addons.manager DEBUG Async provider shutdown done" 18:25:37 INFO - <<<<<<<
Flags: needinfo?(gfritzsche)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 10•9 years ago
|
||
Alessio is taking a look.
Flags: needinfo?(gfritzsche) → needinfo?(alessio.placitelli)
Assignee | ||
Comment 11•9 years ago
|
||
After tracing down this issue, I found that |TelemetrySession._removeAbortedSessionPing| was not correctly handling the exception. This patch fixes the behaviour for 39 beta.
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Flags: needinfo?(alessio.placitelli)
Attachment #8605095 -
Flags: review?(gfritzsche)
Comment 12•9 years ago
|
||
Comment on attachment 8605095 [details] [diff] [review] bug1164007.patch Review of attachment 8605095 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetrySession.jsm @@ +2096,5 @@ > const FILE_PATH = OS.Path.join(OS.Constants.Path.profileDir, DATAREPORTING_DIRECTORY, > ABORTED_SESSION_FILE_NAME); > + return OS.File.remove(FILE_PATH) > + .then(() => this._log.trace("_removeAbortedSessionPing - success"), > + ex => this._log.error("_removeAbortedSessionPing - error removing ping", ex)); If you use .catch() instead then you would also catch any errors in the success handler.
Attachment #8605095 -
Flags: review?(gfritzsche) → review+
Comment 13•9 years ago
|
||
For trunk, if that reproduces, can we trigger that behavior in a test to get coverage?
Assignee | ||
Comment 14•9 years ago
|
||
Thanks Georg, addressed your comment.
Attachment #8605095 -
Attachment is obsolete: true
Attachment #8605123 -
Flags: review+
Reporter | ||
Updated•9 years ago
|
Updated•9 years ago
|
Assignee | ||
Comment 18•9 years ago
|
||
As discussed over IRC, this patch makes sure removeAbortedSessionPing correctly logs if no file is available. test_TelemetrySession.js [1] already implicitly covers shutting down with no aborted-session ping. [1] - https://hg.mozilla.org/mozilla-central/annotate/617dbce26726/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js#l1330
Attachment #8605337 -
Flags: review?(gfritzsche)
Assignee | ||
Updated•9 years ago
|
Attachment #8605337 -
Flags: review?(gfritzsche)
Updated•9 years ago
|
Whiteboard: [uplift]
Assignee | ||
Comment 19•9 years ago
|
||
Comment on attachment 8605337 [details] [diff] [review] [Fx-mc] - Make sure removeAbortedSessionPing catches file not found errors I'm r? you again on this, but it should land after bug 1164822 lands to be useful.
Attachment #8605337 -
Flags: review?(gfritzsche)
Updated•9 years ago
|
Severity: blocker → normal
Comment 20•9 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #18) > Created attachment 8605337 [details] [diff] [review] > [Fx-mc] - Make sure removeAbortedSessionPing catches file not found errors > > As discussed over IRC, this patch makes sure removeAbortedSessionPing > correctly logs if no file is available. > > test_TelemetrySession.js [1] already implicitly covers shutting down with no > aborted-session ping. I may have forgotten that since our IRC conversation - but if that test already covers it, why didn't it show the error before? I think we want better test-coverage here unless it's a big effort.
Assignee | ||
Comment 21•9 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #20) > > test_TelemetrySession.js [1] already implicitly covers shutting down with no > > aborted-session ping. > > I may have forgotten that since our IRC conversation - but if that test > already covers it, why didn't it show the error before? > I think we want better test-coverage here unless it's a big effort. Right now we are never getting into the |catch (ex if ex.becauseNoSuchFile)| branch, because |OS.File.remove| never throws: it's missing the "ignoreAbsent: false" option, so it ignores missing files by default. This patch adds the option and moves the log line after the OS.File.remove, so that it actually gets printed only after a successful removal. That's a minor change: the problem that was present in 39 didn't exist in m-c.
Updated•9 years ago
|
Attachment #8605337 -
Flags: review?(gfritzsche) → review+
Comment 22•9 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #21) > That's a minor change: the problem that was present in 39 didn't exist in > m-c. What i was getting at - if we had a problem like on 39, will we see a test failure?
Assignee | ||
Comment 23•9 years ago
|
||
I've changed a bit this patch to add test coverage. I'm explicitly removing the aborted session file in |test_AbortedSession| within the test_TelemetrySession.js file, so that an exception is thrown during shutdown. I've verified that, with he code from Fx39, this test breaks: we should be safe.
Attachment #8605337 -
Attachment is obsolete: true
Attachment #8608605 -
Flags: review?(gfritzsche)
Assignee | ||
Updated•9 years ago
|
Attachment #8608605 -
Flags: review?(gfritzsche)
Assignee | ||
Comment 24•9 years ago
|
||
This patch makes the test self-contained.
Attachment #8608605 -
Attachment is obsolete: true
Attachment #8608630 -
Flags: review?(gfritzsche)
Updated•9 years ago
|
Attachment #8608630 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 25•9 years ago
|
||
Try push for the m-c version: https://treeherder.mozilla.org/#/jobs?repo=try&revision=963bc79570de
Assignee | ||
Comment 26•9 years ago
|
||
Yay! All green. The checkin-needed is only for the patch marked as [Fx-mc].
Keywords: checkin-needed
Reporter | ||
Comment 27•9 years ago
|
||
Be sure to nominate this for Aurora approval when you get a chance too.
Comment 28•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/15b1703ee712
Keywords: checkin-needed
Assignee | ||
Comment 29•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #27) > Be sure to nominate this for Aurora approval when you get a chance too. Do you think that's needed even though this patch only really adds test coverage? The problem was already fixed on m-c.
Reporter | ||
Comment 30•9 years ago
|
||
What happens when Aurora40 merges to Beta in a few weeks?
Assignee | ||
Comment 31•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #30) > What happens when Aurora40 merges to Beta in a few weeks? Well, hopefully nothing :-) Aurora40 already has this fixed [1], 39 didn't. This patch just adds test coverage and makes sure the proper message is printed if a file is not found. [1] - https://hg.mozilla.org/releases/mozilla-aurora/file/dce1bb4fe6d8/toolkit/components/telemetry/TelemetryStorage.jsm#l852
Reporter | ||
Comment 32•9 years ago
|
||
OK, thanks for explaining :)
https://hg.mozilla.org/mozilla-central/rev/15b1703ee712
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 34•9 years ago
|
||
Comment on attachment 8605123 [details] [diff] [review] [Fx39] - bug1164007.patch - v2 Approval Request Comment [Feature/regressing bug #]: Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2. [User impact if declined]: Data & measurement insight projects delayed or blocked with direct impact on projects depending on this. [Describe test coverage new/current, TreeHerder]: We have good automation coverage of the feature. We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here. [Risks and why]: Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports. We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements. [String/UUID change made/needed]: The only string changes were to the about:telemetry page. We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.
Attachment #8605123 -
Flags: approval-mozilla-aurora?
Comment 35•9 years ago
|
||
Comment on attachment 8608630 [details] [diff] [review] [Fx-mc] - Make sure removeAbortedSessionPing catches file not found errors - v2 Approval Request Comment [Feature/regressing bug #]: Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2. [User impact if declined]: Data & measurement insight projects delayed or blocked with direct impact on projects depending on this. [Describe test coverage new/current, TreeHerder]: We have good automation coverage of the feature. We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here. [Risks and why]: Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports. We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements. [String/UUID change made/needed]: The only string changes were to the about:telemetry page. We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.
Attachment #8608630 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8605123 -
Flags: approval-mozilla-aurora?
Comment 36•9 years ago
|
||
Georg, I am not sure to understand here. It is marked as fixed for 40 (and 39)
Flags: needinfo?(gfritzsche)
Comment 37•9 years ago
|
||
40 & 41 happened to be unaffected, but the flagged patch provides test-coverage (which was only on 41 so far).
Flags: needinfo?(gfritzsche)
Comment 38•9 years ago
|
||
ok, updating the flag to make sure that the Sheriff sees it.
Updated•9 years ago
|
Attachment #8608630 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•