Closed Bug 1164036 Opened 4 years ago Closed 4 years ago

Need an automated test for graphics blocklist versionRange attribute

Categories

(Core :: Graphics, defect)

40 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: milan, Assigned: milan)

References

Details

Attachments

(1 file)

Right now the tests were done manually, but we need automated tests to check what happens when we have versionRange attribute:

minVersion == current == maxVersion
minVersion == current < maxVersion
minVersion < current == maxVersion
minVersion < current < maxVersion
current < minVersion, with and without maxVersion
maxVersion < current, with and without minVersion
versionRange exists, but neither minVersion nor maxVersion are specified
maxVersion < current < minVersion
maxVersion == current < minVersion
maxVersion < current == minVersion
Assignee: nobody → milan
OS: Unspecified → All
Hardware: Unspecified → All
Nothing complicated here, except rigging some results so that they pass on Linux (without actually testing anything there.)
Attachment #8606363 - Flags: review?(bugmail.mozilla)
Comment on attachment 8606363 [details] [diff] [review]
Automated test for versionRange in downloadable blocklist. r=kats

Review of attachment 8606363 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Might also be handy to extend the test to cover scenarios where the app version is something like 15.0a2 (i.e. not a release version), but the version comparator code might already be exercised in other tests, I don't know.
Attachment #8606363 - Flags: review?(bugmail.mozilla) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=358d6c8df74c + https://treeherder.mozilla.org/#/jobs?repo=try&revision=077998c3c692 combined try runs for a few bugs in the series.

And, yes, the version comparator is exercised in gtests part of bug 1162530.
https://hg.mozilla.org/mozilla-central/rev/b5fc35747dd4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.