Closed Bug 1164051 Opened 10 years ago Closed 10 years ago

Compare chooser should be centered

Categories

(Tree Management :: Perfherder, defect)

Product:
Tree Management
Component:
Perfherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wlach, Assigned: tushar1995)

Details

(Keywords: ateam-summer-of-contribution)

User Story

Thank you for helping out with Treeherder!

You can find us on IRC at irc://irc.mozilla.org/treeherder

Here's some links to help get you started.

Project page:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder

Interacting with us, repo locations and links to set up a development version of the software:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs

A-Team general reference, coding style guides:
https://ateam-bootcamp.readthedocs.org

Attachments

(1 file)

PR
46 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
This is a relatively trivial bug: the perfherder chooser content here: https://treeherder.mozilla.org/perf.html#/comparechooser ... would look better if it was in the center of the page, rather than in the top left corner. This should be relatively easy to do using flexbox: https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Using_flexbox_to_lay_out_web_applications An existing example of a similar page with centered content would be my meditation app here: http://meditation.wrla.ch/ https://github.com/wlach/meditation
Hi! Could I be assigned to this bug? I feel it'll be a good starter bug for me to get involved with Perfherder.
perfect! To do this, we work on github: https://github.com/mozilla/treeherder and submit a pull request from a forked copy. Then we usually ask for review in the bug and paste in the pull request URL so we are well aware of it. Do ask questions as they come up! Looking forward to your PR.
Assignee: nobody → tushar1995
I've submitted a PR: https://github.com/mozilla/treeherder/pull/618 It would be great if someone could review this and give me feedback!
Status: NEW → ASSIGNED
User Story: (updated)
Hi Tushar, can you add the PR as a text attachment to this bug? Per the instructions at https://ateam-bootcamp.readthedocs.org/en/latest/guide/development_process.html > Git and Github You can set Joel as r? reviewer in the attachment. Thanks!
(In reply to Jonathan French (:jfrench) from comment #4) > You can set Joel as r? reviewer in the attachment. Thanks! Actually, looking at the PR, I defer to Joel... there's some flex stuff there, perhaps wlach will prefer to review it to ensure its optimization. He's back Wed/Thurs.
Attached file PR —
Almost missed this. Adding myself to review the PR. :)
Attachment #8621686 - Flags: review?(wlachance)
Attachment #8621686 - Flags: review?(wlachance) → review+
Merged PR, resolving. Thanks Tushar!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: