Closed
Bug 1164056
Opened 9 years ago
Closed 9 years ago
use provisionerId in buildbot bridge routing key
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
(Whiteboard: [bbb])
Attachments
(2 files)
4.20 KB,
patch
|
jonasfj
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
2.19 KB,
patch
|
dustin
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
We only look at workerType right now, which is only unique per provisioner.
Comment 1•9 years ago
|
||
Just change lines: > routing_key="*.*.*.*.*.*.%s.#" % worker_type, To: > routing_key="*.*.*.*.*.%s.%s.#" % (provisioner_id, worker_type), And add provisioner_id to the configuration file.
Assignee | ||
Comment 2•9 years ago
|
||
Super simple! Worked fine in dev.
Comment 3•9 years ago
|
||
Comment on attachment 8605414 [details] [diff] [review] add provisioner id to routing key Review of attachment 8605414 [details] [diff] [review]: ----------------------------------------------------------------- Looks great!
Attachment #8605414 -
Flags: review?(jopsen) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8605414 -
Flags: checked-in+
Assignee | ||
Comment 4•9 years ago
|
||
This will add the new, required config item to the bbb config and bump the version to pick up the new code.
Attachment #8605440 -
Flags: review?(dustin)
Updated•9 years ago
|
Attachment #8605440 -
Flags: review?(dustin) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8605440 -
Flags: checked-in+
Assignee | ||
Comment 5•9 years ago
|
||
I just gave this a try in production and it's working well!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Whiteboard: [bbb]
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•