Closed Bug 1164056 Opened 5 years ago Closed 5 years ago

use provisionerId in buildbot bridge routing key

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

(Whiteboard: [bbb])

Attachments

(2 files)

We only look at workerType right now, which is only unique per provisioner.
Just change lines:
>   routing_key="*.*.*.*.*.*.%s.#" % worker_type,

To:
>   routing_key="*.*.*.*.*.%s.%s.#" % (provisioner_id, worker_type),

And add provisioner_id to the configuration file.
Super simple! Worked fine in dev.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8605414 - Flags: review?(jopsen)
Comment on attachment 8605414 [details] [diff] [review]
add provisioner id to routing key

Review of attachment 8605414 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #8605414 - Flags: review?(jopsen) → review+
Attachment #8605414 - Flags: checked-in+
This will add the new, required config item to the bbb config and bump the version to pick up the new code.
Attachment #8605440 - Flags: review?(dustin)
Attachment #8605440 - Flags: review?(dustin) → review+
Attachment #8605440 - Flags: checked-in+
I just gave this a try in production and it's working well!
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [bbb]
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.