Closed Bug 1164140 Opened 9 years ago Closed 9 years ago

Sync should specify Firefox for iOS User-Agent

Categories

(Firefox for iOS :: Sync, defect)

Product:
Firefox for iOS
Component:
Sync
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios - ---

People

(Reporter: wesj, Assigned: atulagrwl, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=swift])

Attachments

(1 file, 2 obsolete files)

Pull request
47 bytes, text/x-github-pull-request
Details | Review 
Sync uses Alamofire. We should try and make sure their UA is right.
Tracking this, but unless sync is doing UA sniffing, I'm fine not tracking it.
tracking-fennec: --- → +
Blocks: 1151960
Assignee: nobody → nalexander
One-line change to StorageClient.swift, so this can stay tracked :)
Assignee: nalexander → nobody
No longer blocks: 1151960
Mentor: rnewman
Component: General → Sync
Summary: Alamofire should use Firefox for iOS Useragent → Sync should specify Firefox for iOS User-Agent
Whiteboard: [good first bug][lang=swift]
Assignee: nobody → nalexander
Blocks: 1151960
Status: NEW → ASSIGNED
tracking-fennec: + → ---
tracking-fxios: + → -
Hardware: Other → All
Assignee: nalexander → nobody
Status: ASSIGNED → NEW
Assignee: nobody → atulagrwl
Attached file Pull request (obsolete) — 

        Attachment #8645298 -
        Flags: review?(rnewman)

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8645298 [details] [review]
Pull request

Comment on the PR. Thanks for grabbing this!

        Attachment #8645298 -
        Flags: review?(rnewman) → review-

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request (obsolete)
        — 
      

    


  

        Attachment #8645298 -
        Attachment is obsolete: true

        Attachment #8645308 -
        Flags: review?(rnewman)

    
    

    
  
Made the changes suggested.

    
    

    
  
Comment on attachment 8645308 [details] [review]
Pull request

A few changes; see comments on PR.

        Attachment #8645308 -
        Flags: review?(rnewman) → feedback+

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request
        — 
      

    


  

        Attachment #8645308 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8645308 [details] [review]
Pull request

Cleaned up and merged: 3a910bc

        Attachment #8645308 -
        Flags: feedback+ → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 1192826

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: