Closed
Bug 1164161
Opened 9 years ago
Closed 9 years ago
Panel dictionary file missing entries for some languages
Categories
(Firefox :: Pocket, defect)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
Firefox 41
People
(Reporter: nate+bugzilla, Assigned: nate+bugzilla)
Details
Attachments
(1 file)
7.51 KB,
patch
|
jaws
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-beta+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
Peter noted that we had some conflicts in dictionary.js: https://github.com/Pocket/Firefox/issues/71 We found that non-English languages were missing or had keys not matching up for 3 strings: - saving: "Saving..." (Missing) - mustbeconnected: "You must be connected to the Internet in order to save to Pocket. Please check your connection and try again." (Missing) - errorgeneric: "There was an error when trying to save to Pocket." (Not matching) Note, this isn't a last minute Beta blocker as the fallback will be not to show any string. In the three cases above it's okay because: - saving: It shows a spinner, actually looks normal without it - mustbeconnected: Still has the main header of the error dialog that says "Page Not Saved" -- it just won't explain why. - errorgeneric: Very rare error state, only will happen if Pocket is completely knocked out. Still has the main header of the error dialog that says "Page Not Saved" -- it just won't explain why. We had strings for those from our own translations so I dropped them in. That said, I assume you'll want to have your localization team review/update as needed. But hopefully this let's us move quickly if needed.
Attachment #8604828 -
Flags: review?(jaws)
Updated•9 years ago
|
Attachment #8604828 -
Flags: review?(jaws) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
Comment on attachment 8604828 [details] [diff] [review] dictionaryFixv2.patch [Triage Comment] a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604828 -
Flags: approval-mozilla-release+
Attachment #8604828 -
Flags: approval-mozilla-beta+
Attachment #8604828 -
Flags: approval-mozilla-aurora+
Comment 4•9 years ago
|
||
(aurora currently closed) https://hg.mozilla.org/releases/mozilla-beta/rev/b2d357bd9c8b https://hg.mozilla.org/releases/mozilla-release/rev/98b2f2b5af65
https://hg.mozilla.org/mozilla-central/rev/08dbb2a63a6b
Assignee: nobody → nate
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•